Release #20

Merged

lambadalambda merged 22 commits from develop into stable 2026-05-13 14:01:22 +00:00

Conversation 0 Commits 22 Files changed 22 +374 -133

lambadalambda commented 2026-05-13 14:01:00 +00:00

Owner

Copy link

No description provided.

lambadalambda added 22 commits 2026-05-13 14:01:00 +00:00

Use pkg-config to discover libmagic paths 3ee9e73ddb

Fix tests on macOS with Homebrew libmagic ... 16cb4f9f60

- Remove ei_init() call that fails when sysconf(_SC_OPEN_MAX) returns
  LONG_MAX (unlimited fd limit on macOS), causing int overflow in
  Erlang's init_socket_info(). The port only uses ei for
  encoding/decoding, not node connections.
- Redirect port stderr to /dev/null unless MAJIC_DEBUG is set, to
  suppress libmagic warnings in test output.
- Compile test .mgc with matching file binary from Homebrew file-formula
  to avoid version mismatch with the linked libmagic.
- Increase port test receive timeout to accommodate slower port startup.
- Broaden .gitignore to cover /priv/ and *.mgc.

Fix Once.perform/3 leaking server process on error ... 7f938fb686

Use try/after to ensure server is always stopped, even when
Server.perform returns {:error, _}.

Fix Pool.terminate_worker/3 not stopping server processes ... 4ed8b5c8a2

Workers were orphaned on pool shutdown. Now calls
Majic.Server.stop/1 on each worker before returning.

Fix Extension.fix/3: directory paths, uppercase extensions, trailing dot ... 62e092b87b

- Preserve directory component when rewriting filename (Path.join)
- Compare old extension case-insensitively (.JPEG matches .jpeg)
- Strip extension properly when no MIME candidates exist (no trailing dot)
- Use Path.basename(name) for append branches to avoid directory duplication

Rewrite Majic.Plug with recursive transform, unskip test ... 16bf0b2bff

Replace fragile collect_uploads/put_in_if_exists approach with
recursive transform_uploads that correctly handles nested maps,
arrays, and structs. Only transform body_params, then merge with
query_params to avoid processing uploads twice. Unskip plug test
and enable fix_extension option.

Fix Majic.perform once:true ignoring :timeout option ... fc689178ab

Extract timeout from opts and pass as 3rd argument to
Once.perform/3, consistent with how Server and Pool paths handle it.

Postpone reload/recycle in non-available states, handle late data in recycling ... d66006f5f5

Calling reload or recycle during processing/starting/loading/recycling
previously crashed the server. Now these calls are postponed until the
server returns to :available. Also discard late {:data, _} messages in
recycling state instead of crashing. Fix :eaccess -> :eacces typo and
add is_port guard in terminate/3.

Fix Plug raising on majic error instead of falling back ... 331f7afef4

When Majic.perform fails (e.g. temp file deleted, permission denied,
pool timeout), return the original upload unchanged instead of raising
a 500 error.

Add Woodpecker CI pipeline for lint and unit tests ... b634668f08

Lint pipeline: mix format --check-formatted, credo
Unit test pipeline: mix test --trace --preload-modules
Both use elixir:1.17-alpine with file-dev for libmagic headers.

Fix outdated references in README and update CHANGELOG ... dc8f9d47dc

README: fix function names (Once.perform/3, start_option/0),
remove references to nonexistent Majic.Helpers.perform_once/2,
clarify Plug fix_extension is opt-in, fix recycle_threshold typo.

CHANGELOG: remove nonexistent Majic.compile/2, add Fixed section
with all bug fixes, add macOS/Homebrew build support and Woodpecker CI.

Fix format and credo issues for CI ... a8cbe3c4a1

- Run mix format on all files
- Reduce Extension.do_fix cyclomatic complexity below 9
  by extracting fix_existing_ext and fix_no_ext helpers
- Remove unused has_candidates? variable

Fix CI: add file package, use plain text magic file instead of .mgc ... aac3cb655f

- Add 'file' to apk packages (needed for C port, not just file-dev)
- Clean stale macOS binary before compile on CI
- Use plain text magic file directly instead of compiled .mgc
  (.mgc format is version-dependent and breaks across different
  libmagic versions)

Fix README: reference Majic.perform with once: true, not Once.perform directly dbd654d0e6

Merge pull request 'Fix macOS build, process leaks, extension handling, plug, and add CI' (#16) from fix/homebrew-libmagic-paths into develop ... 1f235da0fa

Reviewed-on: #16

Bump version to 1.1.0 e7600acc30

Merge pull request 'Bump version to 1.1.0' (#17) from bump/version into develop ... 3cc57fc834

Reviewed-on: #17

Merge branch 'stable' into merge/stable-into-develop ... 0f23c16ec3

# Conflicts:
#	CHANGELOG.md
#	mix.exs

Bump version to 1.2.0 57a011f17e

Merge pull request 'Merge stable into develop' (#18) from merge/stable-into-develop into develop ... e81db2085a

Reviewed-on: #18

Merge branch 'develop' into bump/v1.2.0 3886a6c834

Merge pull request 'Bump version to 1.2.0' (#19) from bump/v1.2.0 into develop ... d32d442441

Reviewed-on: #19

lambadalambda merged commit 1f2df25ccc into stable 2026-05-13 14:01:22 +00:00

lambadalambda referenced this pull request from a commit 2026-05-13 14:01:22 +00:00

Merge pull request 'Release' (#20) from develop into stable

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

pleroma-elixir-libraries/majic!20

No description provided.