Skip to content
Snippets Groups Projects
  1. Mar 21, 2020
    • mayaeh's avatar
      44292a69
    • Jeong Arm's avatar
      Make bookmarks also searchable (#13271) · 8c42e0b5
      Jeong Arm authored
      8c42e0b5
    • Daniel Sockwell's avatar
      Fix frontend crash when deleting announcements (#13283) · 8758221e
      Daniel Sockwell authored
      This two-line change fixes a crash in the front end that occurred
      under the following circumstances:
       *  A server had more than one announcement,
       *  A user was displaying the announcements, and
       *  An announcement was deleted (or unpublished, which amounts to
          the same thing.)
      
      As might be expected, the bug was caused by attempting to access a
      notification using an index value outside the bounds of the existing
      announcements.  Specifically, in two places.  First,
      `_markAnnouncementAsRead` attempts to modify announcements based on
      the current index.  This is what caused the front end crash.  Second,
      when rendering the `Announcements` component, the code paginates the
      announcements and displays the current one.  This did not cause a
      crash, but caused the front end to confusingly display a blank
      announcement (in situations that would have caused a crash) with no
      way for the user to navigate back to previous announcements.
      
      This commit fixes both issues by adding a check to ensure that the
      code never attempts to access an announcement with an index greater
      than or equal to the number of announcements present.
      8758221e
    • Shlee's avatar
      Decommission support for Ruby 2.4 (#13287) · b5dace62
      Shlee authored
      * Update Gemfile
      
      * Update README.md
      b5dace62
    • ThibG's avatar
  2. Mar 18, 2020
  3. Mar 17, 2020
  4. Mar 12, 2020
  5. Mar 10, 2020
  6. Mar 09, 2020
  7. Mar 08, 2020
Loading