pleroma/pleroma-api
0
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity

Upgrade to Neutrino 9 - fix #1 #60

Closed
shpuld wants to merge 0 commits from gitlab-mr-iid-58 into master
pull from: gitlab-mr-iid-58
merge into: pleroma:master
Conversation 7 Commits - Files changed -
shpuld commented 2020-10-23 13:57:05 +00:00
Owner
Copy link

It also seems linting wasn't working properly previously, now it did and I ran --fix and did some manual work to fix all lint errors.

I tested build, test and lint that all work on my machine and using gitlab-runner locally. Tried that the built files work with Kenoma.

It also seems linting wasn't working properly previously, now it did and I ran --fix and did some manual work to fix all lint errors. I tested build, test and lint that all work on my machine and using gitlab-runner locally. Tried that the built files work with Kenoma.
shpuld commented 2020-10-26 05:24:11 +00:00
Author
Owner
Copy link

@nastassia.danilova mind checking this out to see if it works for you or if you spot any mistakes? I got some kenoma gitlab CI runs to pass using this branch at least

@nastassia.danilova mind checking this out to see if it works for you or if you spot any mistakes? I got some kenoma gitlab CI runs to pass using this branch at least
shpuld commented 2020-10-26 05:30:43 +00:00
Author
Owner
Copy link

This was added to make async tests work, if I recall correctly, jest used to come with some babel polyfills to do the same but not anymore, so we just import the relevant part here for the tests.

This was added to make async tests work, if I recall correctly, jest used to come with some babel polyfills to do the same but not anymore, so we just import the relevant part here for the tests.
nastassia.danilova commented 2020-10-26 09:44:05 +00:00
Member
Copy link

Seems like everything works fine for me. But I have a couple of questions

  1. What is the benefit of switching yarn to npm?
  2. We ran --watchAll flag in tdd script to run all the tests during the development process before. Will the current '--watch' flag catch the errors in unchanged tests but which are connected with changed functions?
Seems like everything works fine for me. But I have a couple of questions 1. What is the benefit of switching yarn to npm? 2. We ran `--watchAll` flag in `tdd` script to run all the tests during the development process before. Will the current '--watch' flag catch the errors in unchanged tests but which are connected with changed functions?
nastassia.danilova commented 2020-10-26 09:46:34 +00:00
Member
Copy link
  1. Can we add the launch of lint-fix script before commit git hook?
3. Can we add the launch of `lint-fix` script before commit git hook?
shpuld commented 2020-10-26 10:21:52 +00:00
Author
Owner
Copy link

  1. I figured it'd be consistent with how the script updates pleroma-api on kenoma side, and afterwards I thought removing yarn requirement might be better if any other developers want to utilize the library.

  2. we can change it back if we notice issues with it, --watch just seems to be the recommended way in documentation I saw. Currently our tests are fast enough that maybe --watchAll has no downsides at all

  3. we could do that too, although it won't get rid of all lint errors but it might help

1) I figured it'd be consistent with how the script updates pleroma-api on kenoma side, and afterwards I thought removing yarn requirement might be better if any other developers want to utilize the library. 2) we can change it back if we notice issues with it, `--watch` just seems to be the recommended way in documentation I saw. Currently our tests are fast enough that maybe `--watchAll` has no downsides at all 3) we could do that too, although it won't get rid of all lint errors but it might help
shpuld commented 2020-10-26 11:46:50 +00:00
Author
Owner
Copy link

changed --watch to --watchAll again, installed husky for precommit hooks, and yeah it fails the commit if the --fix can't do its job so that's good

changed `--watch` to `--watchAll` again, installed `husky` for precommit hooks, and yeah it fails the commit if the --fix can't do its job so that's good
nastassia.danilova commented 2020-10-26 12:43:12 +00:00
Member
Copy link

fine

fine

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-api!60
No description provided.