Clicking on @user in messages/notifications navigates you away from the site

It would be better to always link to the shadow copy of their profile on the local instance instead of sending the user off the site. This behavior currently is confusing and frankly silly.

This image should clarify what's going on. Our parsing of @username in a message is producing the wrong URL. We want the behavior of clicking on /users/1234 not /users/lain or a URL to the user's profile on the remote server.

Not until we fix bugs with user profiles, but otherwise i support this.

also /users/:nickname and /users/:userid are interchangeable

What bugs are you referring to?

also /users/:nickname and /users/:userid are interchangeable

yes but the behavior of the URLs in this instance are not. For some reason even the users on your own instance with :nickname have links with (I believe) a target="_blank", but the ones with :userid do not. Something weird is going on.

i'm not entirely sure, but currently user profiles spazz out when you switch users. I.e. opening up your own profile and opening someone else's from there it'll open up their profile and switch back to your own or something. I'm not sure if an issue about that exists.

Something weird is going on.

yeah, it's a bug, i think it's pleroma#169 (closed) or maybe not, i'm not entirely sure. either way, needs to be fixed to be consistent, yeah.

I think the bugs with user profiles were fixed in this commit:

b33aa46d

No, that's a separate issue.

I can work on this

trying to reproduce locally

was able to reproduce this locally

@feld there is no target =_blank on the link but I observed that the id link for me was http://localhost:8080/users/3 but the reply link was http://localhost:4000/users/<name>

so the reply link which has the username seems to point to the upstream url hence its getting navigated to a new page

@oceanvald link inside post message do lead to other instance's profile, that's currently intended behaviour. They do however open up a new tab, it is handled separately in JS.

Making all profile links direct to local copy of profile/tag should probably be done in same MRs as #195 (closed) though I feel BE needs to do something about it too (see my comment in 195).

URL doesn't matter tho.

so just a TLDR; @hj we don't want to open a new tab when clicked on a profile link and rather open it on the same tab?

1. Right now: any link inside post should open in a new tab, including users, hashtags, groups and whatever else.
2. As with #195 (closed) it would be great if we could determine that link is something PleromaFE can handle itself - i.e. for user link open up local copy of user profile, for tag open local tag search timeline etc, in this case we don't need to open up a new tab, vue router would handle it. For every other link - see pt.1

For second one FE needs to know or determine if a link could be handled. I believe BE knows that but doesn't tell PleromaFE that right now.

so modifications to BE has to done in that case i.e. pt.2 ?

i think so.

well then can we have a ticket in the BE for this change? I can go over that and start working on that @hj

Sure, feel free to open it up. Or just any issue, ever, if you find some bug or feature missing or want anything changed - it's open to discussion.

mentioned in issue pleroma#410 (closed)

opened it pleroma#410 (closed) can you @hj please validate its scope?

added Better behavior label

Did you already resolve this issue @oceanvald? Or did you only add BE part?

This has been fixed.

closed