PleromaFE notification configurability missing

We need to permit configuration of which notifications are received in PleromaFE. Users need to disable notifications for follows, mentions, boosts, favorites per their preference and needs. In the instance I'm launching there will be thousands of follows per day for a group of users and it will make notifications unmanageable and the experience frustrating.

This isn't enough?

@hj I think web push notifications do not respect these settings yet.

Also I honestly would have expected that to be in the user settings not the instance settings

edit: interface settings

Right now "user settings" (or profile edit) only has anything that has some dependency on BE. "instance settings" (please don't call them that, if you want to call them, "preferences" or "interface settings") has everything that's only stored on FE. The separation is confusing and until we have settings sync mechanism it probably should stay that way.

Right now we could just hook up these settings into push notifications registering options.

added Better behavior label

@hj I'm going to add setNotificationVisibility action/mutation to the config module and updatePushNotifications function to update the visibility settings of the web push. How does it sound?

@egor i think you can just use setOption action. Also plz check !433 (merged)

@hj just added my 2¢ to !433 (merged)

so I should add a new case condition to setOption action right?

If i'm not mistaken, changing notification filtering option will trigger setOption which you could listen to and change subscription accordingly.

Right, it will. Then I guess I'll add it to that store.subscribe block with tons of if conditions in main.js. Also, maybe it's time to move this code to a separated file like lib/push_notifications_plugin.js, what do you think?

Sure. Are you gonna implement and separate it right away, or some time later, because !433 (merged) also changes that part rather drastically.

I think it's better to wait until !433 (merged) get merged. Please, let me know if I can help with !433 (merged), perhaps with adding subscription removal from BE.

yeah, that would be perfect, i was about to ask if it exists in BE.

mentioned in merge request !438 (merged)

closed via merge request !438 (merged)

mentioned in commit 754cb23f