Site doesn't load at all on some older browsers

User reported that he got blank screen on my develop instance on mobile chrome, couldn't reproduce it with chrome on my phone but with samsung internet I got the same results.

Did more investigation, the user had older version of chrome (58), which also fails on desktop, so I can at least debug this now.

which android version it is and which chrome verions

updated description just now as I got deeper into it, it's about older chromium

changed title from Site doesn't load at all on some android browsers to Site doesn't load at all on some older browsers

changed the description

Ok spent time in browserstack trying different versions, it seems that chrome 69 and older fails, chrome 70 and newer doesn't. didn't yet find out what causes it to not load

this is what I see in console when it fails to load on chrome 69

the previous pic was on shpposter with older BE which could explain some parts, I get different errors on lain.com

chromatism error means it fails to parse theme data somewhere, i wonder what that A error could be.

i wonder if @lambadalambda merged in !1139 on lain.com

no, i haven't. would be interesting to see if it works with !1139

btw do we have browserstack account or something?

ask @feld about it, he hooked me up with one

interestingly enough, sgsgb works just fine on chrome69 but lain.com does not

I'm guessing the problem could be with new default theme causing issues, since sgsgb uses old, v1 (aka array) default theme

yep. go go sgsgb, open settings -> theme, switch to "Pleroma Dark" -> it errors out and doesn't let you set it up. I'll look into it.

Topological order is fucked up

ok, for whatever reason topological sorting fails there. here's what it should look like:

Given that it doesn't put out the "Cyclic dependency in topoSort, ignoring" in console at all, it's not working.

My only idea is to try to replace Sets used there with arrays since it's the only "advanced" feature used there that could potentially go wrong.

on the other hand I have no idea why Redmond or v1 themes work, the SLOT_ORDERED is fucked beyond recognition

layers are fucked a bit in slot definitions but it shouldn't matter

important note with last two screenshots is that "chatMessage______Link" shoud appear AFTER "link", as well as with other ones.

honestly, I don't know if it's worth the effort to fix the code to work perfectly with really old browsers like that, but what would be nice is wrap it in some error handling so that we can fall back to something that does work (fix default themes somehow and make sure new themes don't become messed up the same way) and give the user a warning with our new fancy notice system. I just want users on old browsers to be able to load the site at all, don't really care if it works perfectly

unless you can figure it out of course then be my guest :)

problem is, at least how it looks to me right now - it's broken at the very core and is basically a miracle it works at all in some cases. The only reasonable/fallback thing to do there is to replace SLOT_ORDERED with codegen constant array, i.e. evaluate it during compile time instead of on client.

I am curious however how did it ended up being broken and gonna investigate further

additionally, FE tries to fetch mutes even if it's not logged in

1293bec77e5137acf64d3536c286f8ba3df284f4 is the first bad commit
commit 1293bec77e5137acf64d3536c286f8ba3df284f4
Author: Shpuld Shpuldson <shp@cock.li>
Date:   Thu Jul 2 10:40:41 2020 +0300

    change storage error one-off into a global notice system

 src/App.js                                         | 10 +--
 src/App.scss                                       |  9 ---
 src/App.vue                                        | 11 +---
 .../global_notice_list/global_notice_list.js       | 15 +++++
 .../global_notice_list/global_notice_list.vue      | 77 ++++++++++++++++++++++
 src/main.js                                        | 16 +++--
 src/modules/interface.js                           | 33 ++++++++--
 src/services/theme_data/pleromafe.js               | 36 +++++++++-
 8 files changed, 167 insertions(+), 40 deletions(-)
 create mode 100644 src/components/global_notice_list/global_notice_list.js
 create mode 100644 src/components/global_notice_list/global_notice_list.vue

i'm 100% it's not the root cause, for whatever reason new default pleroma theme is failing to apply on chrome 69, you can't use it at all.

most likely it jsut reshuffled the order because it added stuff to pleromafe.js

mentioned in merge request !1183 (merged)

closed via merge request !1183 (merged)

mentioned in commit 297a0c1f