Sidebar: Text input fields go too far

Bisect says:

65b6e23c is the first bad commit

There actually is one 'bad' commit before this but this one is the first bad one that compiles

Browser?

can't reproduce neither in chrome nor firefox

I wasn't able to reproduce it either

It's firefox 79 on ubuntu. The only unusual thing about my setup is that i have layout.css.devPixelsPerPx to 1.5, but the same thing happens when i set it to default.

Also getting this.

this one is known, i'll fix it soon

fixed in !1211 (merged)

Doesn't reproduce in Firefox 81 either. It's either customization on instance or some addon messing things up

I thought it was an add on, too, but it does the same in privaet mode without add ons and I don't have any FE modifications on lain.com... Really strange.

Can we somehow do a videocall with you @lambadalambda so that you can present your screen and we figure out in devtools what causes that?

Does it behave the same in other browsers?

It only happens in FF and only after the CSS refactor. Videocall sounds good, I'll ping you on IRC

Found the issue. I have the default font for sans-serif set to Noto Sans CJK JP. If I change that back to the default (Deja Vu Sans), the issue goes away.

thanks, can reproduce now.

Figured it out. <textarea> by default has attribute cols="20" which defines it default/auto size, so it turns out it become bigger than container when used with certain fonts. No idea how exactly it calculates the size of it, but given that dividing textarea's effective width by cols gives somewhere around 15px while font-size is 14px, it seems that it might be using some japanese character as a base, so it's probably font-dependent.

will fix it in !1211 (merged) tonight

fixed with !1211 (merged)

closed

reopened

still happens for me, current develop

ah... now i get it!¹ it's the subject field that makes it grow, it also affects other inputs too, like search in the top and makes emoji reaction picker broken too.

1. TL note: "now i get it!" means "naruhodo"

mentioned in merge request !1043 (merged)

mentioned in merge request !1261 (merged)

mentioned in commit 9ef4d473

closed with merge request !1261 (merged)