Skip to content
Snippets Groups Projects

Versioning the font resources using webpack

Merged Tae Hoon requested to merge 701 into develop
1 unresolved thread

closes #701 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tae Hoon added 1 commit

    added 1 commit

    • 36589f32 - use another fork of fontello-webpack-plugin

    Compare with previous version

  • Maintainer

    Figured out why test fails:

    You added fontello webpack plugin into base webpack config, but html webpack plugin is defined in prod/dev configs, not karma config. It fails because fontello can't find html-webpack-plugin when run through karma.

    I see two options:

    1. Add html plugin to karma config (karma.conf.js)
    2. Remove fontello webpack plugin from base config and add it to dev/prod configs (which would be preferred since we don't need html/font building in karma)
  • Tae Hoon added 1 commit

    added 1 commit

    • d37caeed - add html-webpack-plugin to karma config

    Compare with previous version

  • Author Contributor

    fixed

  • HJ mentioned in commit 7b1d5a4f

    mentioned in commit 7b1d5a4f

  • HJ merged

    merged

  • Please register or sign in to reply
    Loading