Versioning the font resources using webpack
closes #701 (closed)
Merge request reports
Activity
can you be more concise? what do you want to be done here?
Edited by feldThis MR practically moves generated files (i.e. whatever fontello outputs) from directory for static assets to directory for source code. Although loading fonts via webpack might help, it's a very hacky solution, not to mention it might involve some delays (right now fonts are loaded as soon as page is loaded, with webpack it will be loaded some time later). Real solution would be using something like https://github.com/gabiseabra/fontello-webpack-plugin to bundle fonts during build, possibly removing the need for bundling fonts manually.
added 7 commits
-
6640b41f...5096bff1 - 6 commits from branch
develop
- 0082ed83 - versioning the font resources through webpack
-
6640b41f...5096bff1 - 6 commits from branch
added 1 commit
- afd4524c - use another approach for versioning font files
- Resolved by Tae Hoon
Figured out why test fails:
You added fontello webpack plugin into base webpack config, but html webpack plugin is defined in prod/dev configs, not karma config. It fails because fontello can't find html-webpack-plugin when run through karma.
I see two options:
- Add html plugin to karma config (
karma.conf.js
) - Remove fontello webpack plugin from base config and add it to dev/prod configs (which would be preferred since we don't need html/font building in karma)
- Add html plugin to karma config (
mentioned in commit 7b1d5a4f