Skip to content
Snippets Groups Projects

fix sticker picker height in emojo picker

Merged fix sticker picker height in emojo picker
absturztaube/pleroma-fe:fix-sticker-height into develop
3 unresolved threads
Merged absturztaube requested to merge absturztaube/pleroma-fe:fix-sticker-height into develop
3 unresolved threads

fixes height of sticker picker

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/components/emoji_picker/emoji_picker.scss
101 101 }
102 102 }
103 103
104 .stickers-content {
105 min-height: 269px;
    • HJ
      HJ @hj ·
      Maintainer

      can you perhaps show what the bug is?

    • absturztaube
      absturztaube @absturztaube ·
      Author Contributor

      the bug is that the sticker picker stays at 0 height when stickers are done loading. i choose that specific height because it matches the height with the emoji picker. let me take a closer look tomorrow if this can be fixed in a better way

    • Please register or sign in to reply
  • absturztaube added 2 commits

    added 2 commits

    • f6d8f245 - Revert "fix sticker picker height in emojo picker"
    • 7e3a4fa8 - fix invisible tab-switcher in emoji picker

    Compare with previous version

  • absturztaube
    absturztaube @absturztaube ·
    Author Contributor

    @hj please review. the bug was caused partly by absolute positioning of the tabs. this caused them to have a height of 0. i still needed to set a min-height on the tab contents. i made them a big bigger then the 200px on the emoji groups because the picker gets rather small (shows only 2-ish rows) if it gets opened in TL (didn't find a better solution for that yet).

  • HJ
    HJ @hj started a thread on an old version of the diff
    • src/components/sticker_picker/sticker_picker.vue
    46 }
    47 .sticker-picker-content {
    48 .sticker {
    49 display: inline-block;
    50 width: 20%;
    51 height: 20%;
    52 img {
    53 width: 100%;
    54 &:hover {
    55 filter: drop-shadow(0 0 5px var(--link, $fallback--link));
    40 .contents {
    41 min-height: 250px;
    42 .sticker-picker-content {
    43 .sticker {
    44 display: inline-block;
    45 width: 20%;
  • absturztaube added 1 commit

    added 1 commit

    Compare with previous version

  • absturztaube
    absturztaube @absturztaube ·
    Author Contributor

    @hj ok, i switched it to flex. please review.

  • HJ merged

    merged

  • HJ mentioned in commit b739edb5

    mentioned in commit b739edb5

    • Please register or sign in to reply