Skip to content
Snippets Groups Projects

Emoji reactions

Merged Shpuld Shpludson requested to merge feat/emoji-reactions into develop

Requires develop backend that supports latest emoji reaction format.

This MR does:

  • add new reactions with unicode emoji
  • use search to filter through the emoji or pick one of the "common" ones
  • click on existing reactions to add your own or remove it

This MR doesn't:

  • have notifications for reactions
  • update emoji reactions in real time

This MR should still:

  • limit the amount of reactions shown per status

emojireactions2

Edited by lain

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • lain
  • lain
  • lain
  • added 1 commit

    Compare with previous version

  • Looks good apart from the console.logs

  • lain added 1 commit

    added 1 commit

    • cb205036 - Apply suggestion to src/services/api/api.service.js

    Compare with previous version

  • Shpuld Shpludson added 2 commits

    added 2 commits

    • e6291e4e - remove unnecessary anonymous function
    • 4e040797 - Merge branch 'feat/emoji-reactions' of git.pleroma.social:pleroma/pleroma-fe...

    Compare with previous version

  • HJ
  • HJ
  • HJ
    HJ @hj started a thread on the diff
  • 32 justify-content: center;
    33 box-sizing: border-box;
    34 :first-child {
    35 margin-right: 0.25em;
    36 }
    37 :last-child {
    38 width: 1.5em;
    39 }
    40 &:focus {
    41 outline: none;
    42 }
    43 }
    44
    45 .picked-reaction {
    46 border: 1px solid var(--link, $fallback--link);
    47 margin-left: -1px; // offset the border, can't use inset shadows either
    • Maintainer

      if we're styling it as buttons we can use button.pressed (see: Following! button in user profile) instead. I actually improved support for that button state in themes v2.1

    • Author Maintainer

      with most (especially the default) themes I think the pressed doesn't fit nearly so well in these. looks kinda bad and has worse readability

      I'd move these away from looking like buttons preferrably but this middle-ground struck to me as fine for now

    • Please register or sign in to reply
  • HJ
  • HJ
  • HJ
  • HJ
  • HJ
  • Maintainer

    code looks good

  • added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading