Skip to content
Snippets Groups Projects

Indicate whether collapsed statuses contain gallery media or link preview cards

Merged Indicate whether collapsed statuses contain gallery media or link preview cards
xenofem/pleroma-fe:feature-collapsed-media-indicator into develop
1 unresolved thread
Merged xenofem requested to merge xenofem/pleroma-fe:feature-collapsed-media-indicator into develop
1 unresolved thread

Fixes #767 (closed)

Currently this shows a picture icon for any kind of gallery media, if you'd like I can adjust it to distinguish between images and videos.

Merge request reports

Pipeline #22619 passed

Stage: lint
Stage: build
Stage: test

Pipeline passed for e36c39be on xenofem:feature-collapsed-media-indicator

Approval is optional

Merged by Shpuld ShpludsonShpuld Shpludson 5 years ago (Feb 10, 2020 2:50pm UTC)

Merge details

Pipeline #22674 passed

Stage: lint
Stage: build
Stage: test
Stage: deploy

Pipeline passed for 6be62417 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • HJ
    HJ @hj started a thread on the diff
    • src/components/status/status.vue
    277 277 href="#"
    278 278 class="cw-status-hider"
    279 279 @click.prevent="toggleShowMore"
    280 >{{ $t("general.show_more") }}</a>
    280 >
    281 {{ $t("general.show_more") }}
    282 <span
    283 v-if="galleryAttachments.length > 0"
    284 class="icon-picture"
    285 />
    286 <span
    287 v-if="status.card"
    • HJ
      HJ @hj ·
      Maintainer

      i'm not sure if it's needed or the icon should be different because you could post a link that won't generate a card at all

    • xenofem
      xenofem @xenofem ·
      Author Contributor

      Hmmm, looking at link-preview.js, the BE isn't supposed to provide preview cards at all for NSFW statuses, but we still make sure to hide any preview card images that show up in NSFW statuses somehow. If we're paranoid enough to add code to handle that case, I feel like we should be consistently paranoid and indicate the presence of a link, and it's not like it hurts anything to do so. If you have suggestions for a better icon I'm all ears.

    • Shpuld Shpludson
      Shpuld Shpludson @shpuld ·
      Maintainer

      BE doesn't provide cards at all or just without images?

    • Shpuld Shpludson
      Shpuld Shpludson @shpuld ·
      Maintainer

      I don't think we need to treat previewless links differently in general, it makes no difference if there's one or not. the preview is what we want to indicate since it can have images.

    • xenofem
      xenofem @xenofem ·
      Author Contributor

      Yeah, I'm testing status.card which unless I'm very confused should only be truthy if there's a preview card?

    • Shpuld Shpludson
      Shpuld Shpludson @shpuld ·
      Maintainer

      yes you're correct, I'm just saying that we shouldn't worry about previewless links at all anywhere, so this is fine.

    • Please register or sign in to reply
  • xenofem added 1 commit

    added 1 commit

    • e36c39be - Include non-gallery attachments and distinguish between images and videos

    Compare with previous version

  • Shpuld Shpludson merged

    merged

  • Shpuld Shpludson mentioned in commit 6be62417

    mentioned in commit 6be62417

  • xenofem mentioned in merge request !1157 (closed)

    mentioned in merge request !1157 (closed)

    • Please register or sign in to reply