Skip to content
Snippets Groups Projects

Add onInput() function as listener for input events, remove unnecessary compositionupdate listener

Merged xenofem requested to merge xenofem/pleroma-fe:fix-android-emoji-input into develop

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Maintainer

    can you test and report that it's working correctly on:

    • desktop chromium
    • desktop firefox
    • mobile chromium
    • mobile firefox

    also tests failed so something is definitely wrong.

  • Author Contributor

    Thanks for pointing that out. It looks like the failing tests are looking at the first input event when they should be looking at the last input event; previously there was only one input event fired during each test, but my change is causing another input event to be fired while the test condition is being set up. I'll adjust the tests accordingly and check all of those browsers.

  • xenofem added 1 commit

    added 1 commit

    • 525fba0a - EmojiInput tests should be checking the input value on the last input event, not the first

    Compare with previous version

  • Author Contributor

    Corrected the tests, everything's passing on my machine and hopefully here as well. I'll let you know when I've manually tested the browsers.

  • xenofem added 1 commit

    added 1 commit

    • c1e38a44 - EmojiInput tests should be checking the input value on the last input event, not the first

    Compare with previous version

  • Author Contributor

    Confirmed emoji input now works as expected on both Firefox and Chromium on both desktop and Android.

  • HJ mentioned in commit 12cd96bf

    mentioned in commit 12cd96bf

  • HJ merged

    merged

Please register or sign in to reply
Loading