Skip to content

Fix/popover performance

Shpuld Shpludson requested to merge fix/popover-performance into develop
  • Removes "v-tooltip"
  • Adds a new "Popover" component

Some things have changed but it's similar:

  • Does not render stuff until the popovers are activated, this makes a big difference in performance.
  • Now you use slots "content" and "trigger" instead of "popover" and the rest.
  • Less options but defaults that serve our needs well
  • Didn't bother reimplementing that tiny arrow for tooltips
  • Not as many alignment options, can be added if necessary. For example no 'bottom-end' so using just 'bottom'
  • Only top and bottom alignment right now, no left/right for simplicity. We didn't have anything using them.
  • Manual operation uses a close function passed as a slot parameter, and emits to tell parent component when popover is opened/closed.
  • Doesn't attempt to move the popover when scrolling it out of view anymore, which makes it possible to read long posts through the preview even on mobile.
  • You can now mouseover into the status preview without it disappearing, making it possible to click links and open profile inside the preview

Latest benchmarks for loading older statuses 4 times on timeline (time it takes to add the statuses and render the changes):

develop:

  • 2.65s, 2.72s, 2.87s, 2.94s

fix/popover-performance:

  • 0.76s, 0.74s, 0.79s, 0.93s
Edited by Shpuld Shpludson

Merge request reports