Skip to content
Snippets Groups Projects

Refactor: make relationships separate from users

Merged Shpuld Shpludson requested to merge feat/relationship-refactor into develop

haven't yet noticed any obvious downgrades the changes would cause in terms of usability, I can't produce any real UI jumping or added latency anywhere. On the positive note, testing on fosdem.pleroma.lol where relationships aren't provided in statuses everything seems to work correctly. Still need to test all the relationship features more to make sure I'm not missing things

Fixes #819 (closed)

Edited by Shpuld Shpludson

Merge request reports

Pipeline #25477 passed

Pipeline passed for 11862055 on feat/relationship-refactor

Approval is optional

Merged by Shpuld ShpludsonShpuld Shpludson 4 years ago (May 8, 2020 9:14am UTC)

Merge details

Pipeline #25483 passed

Pipeline passed for 47c56ffa on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • lain
  • lain
  • Code looks fine, i'll try this on lain.com and see if i notice anything off.

  • First impressions from running this on lain.com:

    • Noticeable performance boost, timelines load faster.
    • Did not encounter any weird behavior (except noted below), relations look correct
    • Fetching the relationship is extremely fast (< 40ms, half of which is latency)

    The only weird thing I saw is that opening the usercard will sometimes display the default info (not following) for a fraction of a second. It's hard to notice, but it does happen. Maybe only fading these buttons in after we have the relationship info could help.

  • One more thing, currently the relationships are fetched like this:

     let url = `${MASTODON_USER_RELATIONSHIPS_URL}/?id=${id}

    The endpoint actually should take an array of ids and can return multiple results, which might be useful for some cases. See https://docs.joinmastodon.org/methods/accounts/#general-account-actions

    Edited by lain
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading