Skip to content
Snippets Groups Projects

Use 4chan's color for greentext, but only for .greentext

Closed NEETzsche requested to merge NEETzsche/pleroma-fe:neetzsche/greentext into develop
1 unresolved thread

Self-explanatory. I think this is more appropriate, and I didn't make a special variable for it because I can't imagine this exact color getting used anywhere but specifically for greentext.

Merge request reports

Pipeline #27186 passed

Pipeline passed for a7787da2 on NEETzsche:neetzsche/greentext

Approval is optional

Closed by HJHJ 4 years ago (Jun 13, 2020 11:46am UTC)

Merge details

  • The changes were not merged into develop.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • you'd rather change a configurable color to a hardcoded one? sorry but no

    you can just change the color to the exact value in your theme. pleroma is also not 4chan

    • Author Contributor

      $fallback--cGreen gets used in three other places, though. Should we make a special variable just for this?

    • The current approach in your code is still essentially hard coding the value as it's not configurable in the theme, which makes it unusable with some user themes (ie. themes with green background where it blends in)

      for it to be actually useful, it should also be editable in the theme editor, but I'm not sure if we want to add another setting to clutter the intrerface, the green text is an optional thing made for fun for those who want it, not something that important. @hj can have his say about this, I'm not a fan of the idea

    • Please register or sign in to reply
  • reopened

  • NEETzsche added 1 commit

    added 1 commit

    • a7787da2 - Use a variable, configurable color that isn't hard coded.

    Compare with previous version

  • HJ mentioned in merge request !1145 (merged)

    mentioned in merge request !1145 (merged)

  • Maintainer

    i've made a MR !1145 (merged) that allows you to define greentext color separate of global green color, if you want 4chan greentext - make 4chan theme.

  • HJ closed

    closed

Please register or sign in to reply
Loading