Skip to content
Snippets Groups Projects

media description authoring v3

check !1160 (closed) , adds image description setting, I posted screenshots in that MR too lazy to copy over

+ many other changes fixing lingering problems with attachments:

  • you can now expand images in the uploads section (uses attachment component now instead of reimplementing the same crap)
  • videos aren't cropped awkwardly in the uploads section anymore
  • the placeholder links like [IMAGE] etc have been replaced with icon + description
  • fixed bugs with placeholder links trying to open non-images/videos in modals
  • added ability to play audio in modal when you have attachments disabled
  • videos and audio have proper alt/title for descriptions

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • HJ
  • HJ
  • HJ
  • Shpuld Shpludson added 2 commits

    added 2 commits

    • b8ed904c - change px to em
    • 150516df - Merge branch 'xenofem/pleroma-fe-rebased-image-description-authoring' of...

    Compare with previous version

    • Maintainer
      Resolved by Shpuld Shpludson

      doesn't seem to work for me. I enter description, it's being sent:

      -----------------------------144184893912142602491022628126
      Content-Disposition: form-data; name="media_ids[]"
      
      40097808
      -----------------------------144184893912142602491022628126
      Content-Disposition: form-data; name="descriptions"
      
      {"40097808":"benis"}
      -----------------------------144184893912142602491022628126--

      but resulting post still has filename as description

  • Maintainer

    slightly related: clicking "unknown" files still opens up media viewer

  • Maintainer

    i'd use some generic file/document icon for unknown types, link just looks confusing

  • HJ resolved all threads

    resolved all threads

  • Maintainer

    otherwise, codewise lgtm

  • Shpuld Shpludson added 29 commits

    added 29 commits

    • 150516df...b761bcf3 - 27 commits from branch develop
    • 4d25be7c - fix modal types check being broken
    • 87b5f828 - fix conflicts, use file icon instead of link, add support for audio and file icon in cw'd posts

    Compare with previous version

  • added 1 commit

    • d55c09df - fix edge case of videos and unknown files together

    Compare with previous version

  • Shpuld Shpludson added 19 commits

    added 19 commits

    Compare with previous version

  • added 1 commit

    • 84d728b9 - fix issue on posting another status

    Compare with previous version

  • Shpuld Shpludson resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading