Skip to content
Snippets Groups Projects

Fix: notifications fetcher double fetching on every tick

Merged Fix: notifications fetcher double fetching on every tick
fix/remove-extra-notifications-fetch into develop
All threads resolved!
Merged Shpuld Shpludson requested to merge fix/remove-extra-notifications-fetch into develop
All threads resolved!

the problem: it fetches notifications twice on every tick

image

removed some unnecessary pointless code (fetchAndUpdate doesn't do much when the application starts fetching notifications immediately anyway)

changed the notifications fetcher to not do the second fetch if it was going to be the same as the first one

Edited by Shpuld Shpludson

Merge request reports

Pipeline #28070 passed

Stage: lint
Stage: build
Stage: test

Pipeline passed for 9178908c on fix/remove-extra-notifications-fetch

Approval is optional

Merged by Shpuld ShpludsonShpuld Shpludson 4 years ago (Jul 5, 2020 7:03am UTC)

Merge details

  • Changes merged into with b761bcf3.
  • Deleted the source branch.

Pipeline #28072 passed

Stage: lint
Stage: build
Stage: test
Stage: deploy

Pipeline passed for b761bcf3 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Shpuld Shpludson changed the description

    changed the description

    • lain
      lain @lambadalambda ·
      Owner
      Resolved by lain

      This doesn't do an initial fetch if websocket streaming is activated, so you'll have an empty notifications column

  • Shpuld Shpludson added 1 commit

    added 1 commit

    • a3e370e9 - add initial fetching back in a more streamlined way

    Compare with previous version

  • Shpuld Shpludson added 1 commit

    added 1 commit

    • 3ebd4e44 - document the 'mark-as-read-detection' system

    Compare with previous version

  • Shpuld Shpludson resolved all threads

    resolved all threads

  • HJ
  • HJ
    HJ @hj ·
    Maintainer

    lgtm

  • Shpuld Shpludson resolved all threads

    resolved all threads

  • Shpuld Shpludson added 1 commit

    added 1 commit

    • 9178908c - Apply suggestion to src/components/notifications/notifications.js

    Compare with previous version

  • Shpuld Shpludson enabled an automatic merge when the pipeline for 9178908c succeeds

    enabled an automatic merge when the pipeline for 9178908c succeeds

  • Shpuld Shpludson mentioned in commit b761bcf3

    mentioned in commit b761bcf3

  • Shpuld Shpludson merged

    merged

    • Please register or sign in to reply