Skip to content
Snippets Groups Projects

Fix #815: Allow use without cookies, Add a global notice popup system

Merged Fix #815: Allow use without cookies, Add a global notice popup system
All threads resolved!
Merged Shpuld Shpludson requested to merge feat/allow-use-without-cookies into develop
All threads resolved!

Exactly what it says in the title. Previously if you disable cookies the site would not load at all at least on chromium. Now you can use the frontend, even login etc.

To make the alert good I ended up implementing a global notice system so that any code in the application can push an error, warning or info notice like this: const myNotice = dispatch('pushGlobalNotice', { messageKey: "some.i18n.key", messageArgs: ['possible args for i18n string'], timeout: 5000, level: 'error') and dispatch('removeGlobalNotice', myNotice). I hope not allowing messages to be pushed without i18n helps in the long run.

Note: pics don't reflect the actual case of what happens without cookies, I added the warning and info just as a test

image

on mobile on breezy light (testing args as well)

image

Edited by Shpuld Shpludson

Merge request reports

Pipeline #27967 passed

Pipeline passed for 9cac5d94 on feat/allow-use-without-cookies

Approval is optional

Merged by Shpuld ShpludsonShpuld Shpludson 4 years ago (Jul 5, 2020 6:53am UTC)

Merge details

Pipeline #28069 passed

Pipeline passed for af4a26b5 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 1293bec7 - change storage error one-off into a global notice system

    Compare with previous version

  • added 1 commit

    • 685ab4f3 - make the addNotice dispatch return the notice

    Compare with previous version

  • updated the description a lot

  • Shpuld Shpludson changed title from Fix #815 (closed): Allow use without cookies, alert user when storage no work to Fix #815 (closed): Allow use without cookies, Add a global notice popup system

    changed title from Fix #815 (closed): Allow use without cookies, alert user when storage no work to Fix #815 (closed): Allow use without cookies, Add a global notice popup system

  • Shpuld Shpludson changed the description

    changed the description

  • mentioned in issue #784 (closed)

  • added 1 commit

    Compare with previous version

  • Shpuld Shpludson resolved all threads

    resolved all threads

  • HJ
  • Maintainer

    lgtm

  • Shpuld Shpludson resolved all threads

    resolved all threads

  • mentioned in commit af4a26b5

  • Please register or sign in to reply
    Loading