Mobile setting modal behavior fixes

Closes #908 (closed)

added 6 commits

• 463ae072...f0e29629 - 5 commits from branch pleroma:develop
• 73847520 - Fix mobile setting modal behavior: ensure the mobile browser address bar...

Compare with previous version

I would try to listen to resize event on window or any other indication that viewport has been resized and adjust padding to the modal.

this will most likely break scroll in background. I don't entirely understand - does safari/chrome not recalculate vh when showing/hiding the addressbar?

changed this line in version 5 of the diff

You're right, it does break the background scroll when the modal settings is minimized. I've removed this part and replaced it by the body-scroll-lock directive to make it so that the background is only locked when the settings content is visible. iOS needs the background to be locked in order for the foreground scroll not to be glitchy. Specifically, the movement that starts with scroll-up doesn't work regardless of the further direction (but the one that starts with scroll-down does), and sometimes the background is scrolled instead). The lock fixes those.

i thought lock was already in place? weird.

There is a lock but it is applied to the whole modal, which doesn't help in this case since we need it for the scrollable content that is inside the modal

added 1 commit

• 50d3350a - Add body 100% width for the preview, refactor the modalActivated watcher

Compare with previous version

added 1 commit

• d3a6c99a - Add body 100% width for the preview, refactor the modalActivated watcher

Compare with previous version

added 21 commits

• d3a6c99a...25a015b4 - 18 commits from branch pleroma:develop
• dac075c6 - Fix mobile setting modal behavior: ensure the mobile browser address bar...
• 61dd1a3b - Add body 100% width for the preview, refactor the modalActivated watcher, use...
• 6ea840ff - Use bock-scroll-lock directive for the settings modal

Compare with previous version

added 2 commits

• 2298ad00 - Use bock-scroll-lock directive for the settings modal
• ab58d9f9 - Ensures the minimized modal is always 50px above the mobile browser bottom bar...

Compare with previous version

unmarked as a Work In Progress

Ready for final review, tested in Android and iOS (Chrome, Safari, Firefox)

added 1 commit

• 77d65d6c - Ensures the minimized modal is always 50px above the mobile browser bottom bar...

Compare with previous version

I tried with 2 different android phones, firefox and chrome in both, works in all!

approved this merge request

merged

mentioned in commit 9a10ad38