Skip to content
Snippets Groups Projects

User popovers

Closed User popovers
feat/user-popovers into develop
Closed Shpuld Shpludson requested to merge feat/user-popovers into develop

Adds popovers for users so you can view some profile details on mouseover (or tap on mobile) on mentions, avatars, etc.

I removed the inline profile cards from status/notifs in favor of this

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Shpuld Shpludson added 23 commits

    added 23 commits

    Compare with previous version

  • Shpuld Shpludson added 6 commits

    added 6 commits

    Compare with previous version

  • Shpuld Shpludson added 15 commits

    added 15 commits

    • 6b9ce950...4adccf22 - 13 commits from branch develop
    • b3254c99 - fix conflicts
    • 72934c1f - Merge branch 'feat/user-popovers' of git.pleroma.social:pleroma/pleroma-fe into feat/user-popovers

    Compare with previous version

    • Shpuld Shpludson
      Shpuld Shpludson @shpuld ·
      Author Maintainer

      noticed the popovers in chat don't work right, might just disable them over there for now. I don't want to keep maintaining this shit forever before merge.

  • HJ
    HJ @hj ·
    Maintainer

    repeat avatars are fucked
    image

  • HJ
    HJ @hj ·
    Maintainer

    if user has a highlight it's fucked as well
    image

  • HJ
    HJ @hj ·
    Maintainer

    Trying to move mouse to popover sometimes hides it, probably should have some timeout before popover hides if lost hover

  • HJ
    HJ @hj ·
    Maintainer

    popover width isn't fixed, some elements are squished
    image
    image
    image

    Probably should have some minimum width in place.

  • HJ
    HJ @hj ·
    Maintainer

    highlight controls look... weird. I don't think they should occupy as much space as they do.

    image

  • HJ
    HJ @hj ·
    Maintainer

    I would still prefer to have mute button easily accessible

  • HJ
    HJ @hj ·
    Maintainer

    Something is wrong with profile avatar shadows
    image

    Edited by HJ
  • HJ
    HJ @hj ·
    Maintainer

    This probably doesn't need a popup...
    image

  • HJ
    HJ @hj ·
    Maintainer

    dots menu reads "muted" for muted users, seems like for a menu item it should be "Unmute" instead. If it remains as menu item, i would much prefer it to be a button instead.

  • HJ
    HJ @hj ·
    Maintainer

    I feel like showing tooltip on click would be better.

    1. I'm tiggering way too many tooltips by accident which makes UI harder to use, i.e. accidentally hovering over user handle in post header which covers reply-to, or any mentions in the post.
    2. Sometimes briefly hovering over something and leaving leaves the tooltip open for longer than it should, this is probably possible with reply-tos but with sheer amount of user tooltips it's more likely to happen.
  • HJ
    HJ @hj ·
    Maintainer

    I think tooltips should have fixed size and have a bit more vertical space even if nothing occupies space, to show off profile banner image a bit more. Sorta closer to what steam does
    image

  • HJ
    HJ @hj ·
    Maintainer

    play on hover gifs are a bit broken but not part of this issue.

  • HJ
    HJ @hj ·
    Maintainer

    chat list popup doesn't have correct pointer when hovering over links
    image

  • HJ
    HJ @hj ·
    Maintainer

    Users in muted/blocked lists only show "Follow" and no dots menu.

  • HJ
    HJ @hj started a thread on the diff
src/components/moderation_tools/moderation_tools.vue
124 124 </div>
125 125 <button
126 126 slot="trigger"
127 class="btn btn-default btn-block"
128 :class="{ toggled }"
127 :class="`${buttonClass} ${toggled && 'toggled'}`"
  • HJ
    HJ @hj ·
    Maintainer
    Suggested change
    127 :class="`${buttonClass} ${toggled && 'toggled'}`"
    127 :class="[buttonClass, { toggled }]`"
  • Please register or sign in to reply
  • HJ
    HJ @hj started a thread on the diff
    • src/components/notifications/notifications.js
    24 24 bottomedOut: false,
    25 25 // How many seen notifications to display in the list. The more there are,
    26 26 // the heavier the page becomes. This count is increased when loading
    27 // older notifications, and cut back to default whenever hitting "Read!".
    27 // older notifications, and cut back to default whenever hitting "Read!"1.
    • HJ
      HJ @hj ·
      Maintainer
      Suggested change
      27 // older notifications, and cut back to default whenever hitting "Read!"1.
      27 // older notifications, and cut back to default whenever hitting "Read!".
    • Please register or sign in to reply
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply