Skip to content
Snippets Groups Projects

FontAwesome 5

Merged FontAwesome 5
fontawesome5 into develop
1 unresolved thread
Merged HJ requested to merge fontawesome5 into develop
1 unresolved thread

Closes #982 (closed)

Replaces all icons with FA5 counterparts. Removes Fontello

Some icons changed to a (slightly) different icon:

  • All spinners were changed to circle-notch since FA doesn't have any spinners beyond 7-dots and circle-notch ones.
  • bell-ringing is instead a frankenstein of bell and two rss icons to simulate ringing, since bell-on is a FA PRO icon :/
  • Video icon (in hidden attachment placeholder) uses generic camera
  • Poll icon uses horizontal poll icon, i.e. similar to graph but horizontal and inside a square.
  • Smile icon uses beam version, i.e. it does the ^_^ expression. Because people complained that plain :) "stares at them"
  • Smile icon in post form changed to filled variant for better harmony with other icons
  • globe is changed to a generic "basketball"
  • lock now has shackle turned over for better accessibility
  • ellipsis in usercard is vertical instead of horizontal
  • version tab in settings is now information without circle.
  • notifications tab in settings is non-ringing bell
  • maybe more i can't remember.

Some small bugfixes:

  • Icons in navbar have been readjusted
  • Icons in user-card have been readjusted and given MUCH bigger hitbox + better hover indication.
  • Some components like RetweetButton have been refactored.
  • Some components's CSS was changed to fit better with our guidelines.
Edited by HJ

Merge request reports

Pipeline #32322 passed

Stage: lint
Stage: build
Stage: test

Pipeline passed for ef36ca44 on fontawesome5

Approval is optional

Merged by HJHJ 4 years ago (Oct 28, 2020 9:21pm UTC)

Merge details

  • Changes merged into develop with a84db4bd.
  • Deleted the source branch.

  • Closed #982 (closed)

  • Auto-merge enabled

Pipeline #32323 passed

Stage: lint
Stage: build
Stage: test
Stage: deploy

Pipeline passed for a84db4bd on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/components/user_card/user_card.vue
283 311 mask: linear-gradient(to top, white, transparent) bottom no-repeat,
284 312 linear-gradient(to top, white, white);
285 313 // Autoprefixed seem to ignore this one, and also syntax is different
286 -webkit-mask-composite: xor;
314 -webkit-mask-composite: xor;
  • Shpuld Shpludson
  • HJ added 4 commits

    added 4 commits

    • b6cf2bce - improved the semantics for our icon scale, fixed preview, fixed navbar desktop
    • 7c4af4ce - improved side-drawer alignments
    • fc7dfb3b - update & unify the navbars heights
    • 0ac9d817 - fix settings tabs on mobile, update follow request badge

    Compare with previous version

    Toggle commit list
  • HJ
    HJ @hj ·
    Author Maintainer

    Updated:

    • Removed button-icon, replaced with fa-scale-110 (110% icon scale aka font-size: 1.1em) and fa-old-padding, no longer requires size="lg" which also screwed alignment a bit.
    • Updated and optimized layout of both navigation lists (both mobile and desktop) - they use fixed sizing and text alignment is done with line-height instead of padding.
    • Follow requests badge updated to be aligned with vertical-align instead of negative margins, also synced styles between mobile and desktop. Should look much less weird now.
    • Fixed weird alignments in side-drawer
    • Increased size for side-tabs on mobile
  • Shpuld Shpludson
    Shpuld Shpludson @shpuld ·
    Maintainer

    Looking really good now, only thing that sticks out right now is the emoji picker, at first it looks like something is not right because the U has an underline, but selected icon also has an underline

  • HJ added 1 commit

    added 1 commit

    Compare with previous version

  • HJ added 1 commit

    added 1 commit

    Compare with previous version

  • HJ enabled an automatic merge when the pipeline for ef36ca44 succeeds

    enabled an automatic merge when the pipeline for ef36ca44 succeeds

  • HJ mentioned in commit a84db4bd

    mentioned in commit a84db4bd

  • HJ merged

    merged

    • Please register or sign in to reply