Skip to content
Snippets Groups Projects

Misc Chat fixes

Merged Shpuld Shpludson requested to merge fix/chat-misc-fixes into develop
All threads resolved!
  • fix chat back button size to make it easier to hit (especially on mobile)
  • fix chat notifications being marked as read too eagerly, I've had the problem where I've missed quite a few chat messages because they arrive roughly at the same time as I'm leaving the chat view, so it has just enough time to register the messages as read but I didn't have enough time to even notice the new messages. Note that there was some double logic in how things get marked as read, that's why some "forceRead" calls were cut out, it still works like you'd expect.
  • fix promiseinterval erroring when not getting a promise
  • fix an error about lastMessage not having an account property, this was because of a typo with "account.id" instead of "account_id"

Merge request reports

Pipeline #32343 passed

Pipeline passed for 3ead79dd on fix/chat-misc-fixes

Approval is optional

Merged by Shpuld ShpludsonShpuld Shpludson 4 years ago (Nov 1, 2020 5:50pm UTC)

Merge details

  • Changes merged into with 14878976.
  • Deleted the source branch.

Pipeline #32448 passed

Pipeline passed for 14878976 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Shpuld Shpludson added 21 commits

    added 21 commits

    Compare with previous version

  • HJ resolved all threads

    resolved all threads

  • HJ
  • HJ
  • added 1 commit

    Compare with previous version

  • Shpuld Shpludson resolved all threads

    resolved all threads

  • HJ approved this merge request

    approved this merge request

  • Maintainer

    Seems to be working fine. Didn't test the marking as read though.

  • mentioned in commit 14878976

  • Please register or sign in to reply
    Loading