Group staff by role in the About page

Closes #737 (closed)

added 3 commits

• 2d528aab...bdb994d4 - 2 commits from branch pleroma:develop
• 75d9a4d7 - Group staff members by role in the About page

Compare with previous version

looks fine to me, I'll do quick test runs on it tomorrow

btw @eugenijm, not related to this branch itself, but since you've got the developer role in gitlab, you should be able to create your branches upstream, which would make it easier to pull and test and update them :)

When testing, I noticed something interesting, we have situations where staff accounts list contains accounts that aren't tagged with admin or moderator, which probably shouldn't be happening, if you check shitposter.club/about you'll see moonman in the list (deactivated account) as it's still returned in the staff accounts but doesn't have any tags. In this particular case it's probably a good thing we don't show it, but do we have cases with more staff tags than admin/moderator, is it difficult for people to modify their instance to support more tags than just admin and moderator?

cc @lambadalambda @feld , possible bug in returned staff accounts and wondering how the tags work

As a small note, user tags are different from roles on BE: admin and moderator roles are represented as boolean fields in the user record (is_admin, is_moderator) while tags are stored as an array field. So for an instance admin, I think it would be easier to add custom tags (can be done via an API call) than to add new roles as the latter requires extending the codebase and the db schema.

thanks for explaining!

added 31 commits

• 75d9a4d7...8d9bf3ef - 29 commits from branch pleroma:develop
• 481c7151 - Group staff members by role in the About page
• 2dfd9554 - Handle other staff roles

Compare with previous version

mentioned in commit 8b7c367b

merged