Skip to content
Snippets Groups Projects

Some fixes for reactbutton/extrabuttons

Merged HJ requested to merge reactbutton-consistency into develop
  • Cleans up CSS for ReactButton and makes classnames more consistent with rest of buttons.
  • Adds type="button" to popover's button to avoid form issues
  • Fixes hitboxes of extrabuttons and reactbutton:
    image
    Popover's button has 100% width that makes hitbox grow. Kind of a soft fix but maybe something more serious needs to be done for popovers, like not using button at all and let user of component declare button themselves?

Merge request reports

Pipeline #34609 passed

Pipeline passed for 213c5637 on reactbutton-consistency

Approval is optional

Merged by HJHJ 4 years ago (Feb 9, 2021 1:12pm UTC)

Merge details

  • Changes merged into develop with 647d75f2.
  • Deleted the source branch.

Pipeline #34781 passed

Pipeline passed for 647d75f2 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading