Skip to content
Snippets Groups Projects

Change old slot syntax (removed in vue3) to new one

Merged HJ requested to merge v-slot-upgrade into develop
All threads resolved!

In addition it fixes some semi-related issues:

  • Several places where popover is used trigger wasn't a <button>, changed to button.
    • exception - ModifiedIndicator, since it's not really interactive, used aria-label instead to make it accessible and NOT generate a tooltip.
  • Timeline menu (the dropdown home/dms/local/etc switcher) was using panel panel-default classes, switched it to popover-default so that it uses tooltips background (has separate opacity from panels for better visibility)
  • Excessive <div>s that don't do anything replaced with <template>s
Edited by HJ

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • there's a few new warnings introduced (I just check the build job on gitlab) that should be fixed, otherwise if you've tested the affected components that nothing's accidentally broken, looks all good

  • HJ resolved all threads

    resolved all threads

  • HJ added 1 commit

    added 1 commit

    Compare with previous version

  • HJ enabled an automatic merge when the pipeline for 80220c1b succeeds

    enabled an automatic merge when the pipeline for 80220c1b succeeds

  • HJ merged

    merged

  • HJ mentioned in commit 0ca0e642

    mentioned in commit 0ca0e642

  • HJ changed milestone to %Vue 3 support

    changed milestone to %Vue 3 support

  • Please register or sign in to reply
    Loading