Skip to content
Snippets Groups Projects

Attachment improvements

Merged HJ requested to merge proper-attachments into develop
1 unresolved thread

This requires !1392 (merged) due to refactoring done in there

User-facing changes

  1. Attachments now are always in same order as uploaded
  2. Attachments in post-status-form and in post are uniform now.
  3. You can now watch videos in media-modal even if you disabled that option (via zoom icon)
    image
  4. You can now watch flash in media-modal (takes up entire screen tho)
  5. File/image descriptions are pre-filled if your instance prefills descriptions for you
    image
  6. New button that indicates that attachment has a description, clicking it toggles a preview of description
    image
    image
  7. Notifications about favorites/repeats take up less space
    image
  8. Too many attachments are truncated
    image
  9. Display full description in media-modal
    image
    image
  10. Ability to rearrange attachments when making a post, no drag-n-drop yet.
    image
  11. Attachments counter
    image
  12. Proper indication that next image is loading when you press left/right
    image

Technical

  • Gallery now handles all attachment business, period. No more "non-gallery attachments"
  • Attachments now can have edit, remove, move up and down functions for post-status-form
  • Refactored related parts
  • Some improvements to flash component, namely - no longer has its own button for stopping, instead button now is in Attachment component.
Edited by HJ

Merge request reports

Pipeline #38977 passed

Pipeline passed for befd4d5f on proper-attachments

Approval is optional

Merged by HJHJ 2 years ago (Feb 20, 2022 3:11pm UTC)

Merge details

  • Changes merged into develop with ddee8bb6.
  • Deleted the source branch.

Pipeline #39035 passed

Pipeline passed for ddee8bb6 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • HJ added 25 commits

    added 25 commits

    • a0eaac22 - fix tests
    • 2cfff1b8 - remove new options for style and separate line, now groups all chained
    • 2182af40 - made the code responsible for showing unwritten mentions actually work
    • add5921b - fix tests, add performance test (skipped, doesn't assert anything),
    • 6c6df29e - support richcontent in polls
    • 4c974f5c - richcontent support in polls, user cards and user profiles
    • 97e86381 - remove old emoji added, everything emoji-bearing uses RichContent now
    • 4465de52 - fixed mentions line again
    • 530ac444 - removed useless code, review change, fixed bug with tall statuses
    • 7d67e8f1 - remove obsolete tests
    • 68b43231 - prevent infinite update loops
    • f16658ad - fix tests
    • 17d2eed0 - Merge branch 'better-still-emoji' into proper-attachments
    • 6aa6f6f3 - fix console errors
    • 8cc1ad67 - fix links sticking to mentionsline
    • 5431d8fe - Merge branch 'better-still-emoji' into proper-attachments
    • c8a7b6f4 - fix long posts double-fading in notifications
    • 07c12ae1 - replace poll with an icon in notifications
    • 299c00cf - fix video attachments in notifications not having pointer cursor
    • 0087d33c - fix "+X more" sticking
    • 777f6c01 - Merge branch 'better-still-emoji' into proper-attachments
    • f5823a96 - add key attribute to make image refresh in media modal to give feedback
    • 34d26546 - add media description into media modal
    • 830a03a0 - inline description display
    • 0507eb65 - ability to move attachments around when making a new post

    Compare with previous version

  • HJ changed the description

    changed the description

  • HJ added 2 commits

    added 2 commits

    Compare with previous version

  • HJ changed the description

    changed the description

  • HJ added 1 commit

    added 1 commit

    • 49fe3341 - play gifs when hovering over notification

    Compare with previous version

  • HJ mentioned in issue #1097 (closed)

    mentioned in issue #1097 (closed)

  • Author Maintainer

    I'm still not sure about the description button, i feel like it's only useful on mobile and even there it's kind of not good, maybe I'll try using popover?

  • Author Maintainer

    Also zoom button on videos should pause them, i think. Ideally, also seek one in the modal but that's a feature for future i guess.

  • Ilja mentioned in issue pleroma#2780

    mentioned in issue pleroma#2780

  • Ilja mentioned in merge request pleroma!3535 (merged)

    mentioned in merge request pleroma!3535 (merged)

  • HJ added 110 commits

    added 110 commits

    • 49fe3341...182fcca5 - 108 commits from branch develop
    • c551e3e6 - Merge remote-tracking branch 'origin/develop' into proper-attachments
    • 56de3d2f - fix too-many-attachments in notifications column

    Compare with previous version

  • Author Maintainer

    I tried changing description "bar" to a Popover but couldn't make it properly adapt to container width (with word-break: break-all) without drawbacks, seems that description bar is both simpler and easier approach for now.

  • HJ marked this merge request as ready

    marked this merge request as ready

  • HJ added 12 commits

    added 12 commits

    • 56de3d2f...28ee5721 - 9 commits from branch develop
    • 94c37e8a - Merge remote-tracking branch 'origin/develop' into proper-attachments
    • efd558f3 - Merge remote-tracking branch 'origin/develop' into proper-attachments
    • d1f02221 - changelog

    Compare with previous version

  • Author Maintainer

    Found a bug that non-media attachment link-button doesn't do anything when clicked, should prompt to download the file

  • HJ added 1 commit

    added 1 commit

    • befd4d5f - improve unknown attachment handling

    Compare with previous version

  • Author Maintainer

    Improved handling of unknown-type attachments:

    image

    also fixed the bug i mentioned above

  • Author Maintainer

    the description indicator-button is kinda bad on mobile but whole buttons thing is bad on mobile, we might need to somehow adapt/detect column width, maybe for later MR.

  • HJ requested review from @shpuld

    requested review from @shpuld

  • looks fine to me

  • HJ merged

    merged

  • HJ mentioned in commit ddee8bb6

    mentioned in commit ddee8bb6

  • tusooa mentioned in issue #1135 (closed)

    mentioned in issue #1135 (closed)

  • mentioned in commit ilja/pleroma@6eca7b09

  • mentioned in commit ilja/pleroma@dc1dfba1

  • mentioned in commit ilja/pleroma@3c48e299

  • mentioned in commit ilja/pleroma@cd316d72

  • mentioned in commit ilja/pleroma@fb122bb2

  • Duponin mentioned in issue #865 (closed)

    mentioned in issue #865 (closed)

  • Please register or sign in to reply
    Loading