Attachment improvements

This requires !1392 (merged) due to refactoring done in there

User-facing changes

0. Attachments now are always in same order as uploaded
1. Attachments in post-status-form and in post are uniform now.
2. You can now watch videos in media-modal even if you disabled that option (via zoom icon)
   
3. You can now watch flash in media-modal (takes up entire screen tho)
4. File/image descriptions are pre-filled if your instance prefills descriptions for you
   
5. New button that indicates that attachment has a description, clicking it toggles a preview of description
   
   
6. Notifications about favorites/repeats take up less space
   
7. Too many attachments are truncated
   
8. Display full description in media-modal
   
   
9. Ability to rearrange attachments when making a post, no drag-n-drop yet.
   
10. Attachments counter
    
11. Proper indication that next image is loading when you press left/right
    

Technical

• Gallery now handles all attachment business, period. No more "non-gallery attachments"
• Attachments now can have edit, remove, move up and down functions for post-status-form
• Refactored related parts
• Some improvements to flash component, namely - no longer has its own button for stopping, instead button now is in Attachment component.

currently the post form has a problem where attachments are too big when replying on desktop. Thinking how to fix it.

added 1 commit

• 44b741e2 - better attachments in uploading (grid layout)

Compare with previous version

added 1 commit

• 6b8b9c01 - whoops

Compare with previous version

resolved all threads

Videos (and possibly flashes) shouldn't be within an <a>, it makes dragging controls impossible since browser prioritizes dragging link instead

long post cutoff double-overlaying

added 4 commits

• 4016182b - fix z-indexes
• 4ba8d95a - fix videos and related not having working drag controls
• 5118eee1 - fix videos not stretching to container
• 628b99d1 - don't stretch columns when uploading media

Compare with previous version

added 6 commits

• 8fe4355a - fix rich images
• c6831a38 - fix not escaping some stuff
• a2581825 - fix non-notifying mentions and original mention display
• a2f21f4e - fix description colliding with extra-long text
• dd3fe61c - Merge branch 'better-still-emoji' into proper-attachments
• b67db47c - lint

Compare with previous version

I'm not a fan of the super compressed notifications, thumbnail is borderline useless and text has less space too, I can't be the only one who gets long winded replies with an attachment with them.

the additional hover to show media description doesn't sound particularly useful, unless there's a way to trigger it on mobile then it brings something new

it's a bit obtuse and i don't particularly like it myself but i can say it makes it very easy to see if media even has description to begin with.

Since this MR is WIP, i might end up changing it to something else.

hard to say if I'd be annoyed by it or not, but it would be nice to have a way for mobile to see description, just not sure if possible without a specific button for it (always showing it in modal works but limited to modal media only)

the zoom icon seems a bit off for the media modal watching, wonder if there's anything nicer... good addition as a feature tho

added 25 commits

• a0eaac22 - fix tests
• 2cfff1b8 - remove new options for style and separate line, now groups all chained
• 2182af40 - made the code responsible for showing unwritten mentions actually work
• add5921b - fix tests, add performance test (skipped, doesn't assert anything),
• 6c6df29e - support richcontent in polls
• 4c974f5c - richcontent support in polls, user cards and user profiles
• 97e86381 - remove old emoji added, everything emoji-bearing uses RichContent now
• 4465de52 - fixed mentions line again
• 530ac444 - removed useless code, review change, fixed bug with tall statuses
• 7d67e8f1 - remove obsolete tests
• 68b43231 - prevent infinite update loops
• f16658ad - fix tests
• 17d2eed0 - Merge branch 'better-still-emoji' into proper-attachments
• 6aa6f6f3 - fix console errors
• 8cc1ad67 - fix links sticking to mentionsline
• 5431d8fe - Merge branch 'better-still-emoji' into proper-attachments
• c8a7b6f4 - fix long posts double-fading in notifications
• 07c12ae1 - replace poll with an icon in notifications
• 299c00cf - fix video attachments in notifications not having pointer cursor
• 0087d33c - fix "+X more" sticking
• 777f6c01 - Merge branch 'better-still-emoji' into proper-attachments
• f5823a96 - add key attribute to make image refresh in media modal to give feedback
• 34d26546 - add media description into media modal
• 830a03a0 - inline description display
• 0507eb65 - ability to move attachments around when making a new post

Compare with previous version

changed the description

added 2 commits

• 7cc19ef2 - better media modal loading
• 14ec7d6a - add attachment counter

Compare with previous version

changed the description

added 1 commit

• 49fe3341 - play gifs when hovering over notification

Compare with previous version

mentioned in issue #1097 (closed)

I'm still not sure about the description button, i feel like it's only useful on mobile and even there it's kind of not good, maybe I'll try using popover?