Skip to content
Snippets Groups Projects

Attachment improvements

Merged HJ requested to merge proper-attachments into develop

This requires !1392 (merged) due to refactoring done in there

User-facing changes

  1. Attachments now are always in same order as uploaded
  2. Attachments in post-status-form and in post are uniform now.
  3. You can now watch videos in media-modal even if you disabled that option (via zoom icon)
    image
  4. You can now watch flash in media-modal (takes up entire screen tho)
  5. File/image descriptions are pre-filled if your instance prefills descriptions for you
    image
  6. New button that indicates that attachment has a description, clicking it toggles a preview of description
    image
    image
  7. Notifications about favorites/repeats take up less space
    image
  8. Too many attachments are truncated
    image
  9. Display full description in media-modal
    image
    image
  10. Ability to rearrange attachments when making a post, no drag-n-drop yet.
    image
  11. Attachments counter
    image
  12. Proper indication that next image is loading when you press left/right
    image

Technical

  • Gallery now handles all attachment business, period. No more "non-gallery attachments"
  • Attachments now can have edit, remove, move up and down functions for post-status-form
  • Refactored related parts
  • Some improvements to flash component, namely - no longer has its own button for stopping, instead button now is in Attachment component.
Edited by HJ

Merge request reports

Pipeline #38977 passed

Pipeline passed for befd4d5f on proper-attachments

Merged by HJHJ 2 years ago (Feb 20, 2022 3:11pm UTC)

Loading

Pipeline #39035 passed

Pipeline passed for ddee8bb6 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading