Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma-fe pleroma-fe
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 323
    • Issues 323
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleroma-fepleroma-fe
  • Merge requests
  • !1399

Attachment improvements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged HJ requested to merge proper-attachments into develop Jun 18, 2021
  • Overview 21
  • Commits 45
  • Pipelines 11
  • Changes 23

This requires !1392 (merged) due to refactoring done in there

User-facing changes

  1. Attachments now are always in same order as uploaded
  2. Attachments in post-status-form and in post are uniform now.
  3. You can now watch videos in media-modal even if you disabled that option (via zoom icon)
    image
  4. You can now watch flash in media-modal (takes up entire screen tho)
  5. File/image descriptions are pre-filled if your instance prefills descriptions for you
    image
  6. New button that indicates that attachment has a description, clicking it toggles a preview of description
    image
    image
  7. Notifications about favorites/repeats take up less space
    image
  8. Too many attachments are truncated
    image
  9. Display full description in media-modal
    image
    image
  10. Ability to rearrange attachments when making a post, no drag-n-drop yet.
    image
  11. Attachments counter
    image
  12. Proper indication that next image is loading when you press left/right
    image

Technical

  • Gallery now handles all attachment business, period. No more "non-gallery attachments"
  • Attachments now can have edit, remove, move up and down functions for post-status-form
  • Refactored related parts
  • Some improvements to flash component, namely - no longer has its own button for stopping, instead button now is in Attachment component.
Edited Jan 24, 2022 by HJ
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: proper-attachments