Attachment improvements
This requires !1392 (merged) due to refactoring done in there
User-facing changes
- Attachments now are always in same order as uploaded
- Attachments in post-status-form and in post are uniform now.
- You can now watch videos in media-modal even if you disabled that option (via zoom icon)
- You can now watch flash in media-modal (takes up entire screen tho)
- File/image descriptions are pre-filled if your instance prefills descriptions for you
- New button that indicates that attachment has a description, clicking it toggles a preview of description
- Notifications about favorites/repeats take up less space
- Too many attachments are truncated
- Display full description in media-modal
- Ability to rearrange attachments when making a post, no drag-n-drop yet.
- Attachments counter
- Proper indication that next image is loading when you press left/right
Technical
- Gallery now handles all attachment business, period. No more "non-gallery attachments"
- Attachments now can have edit, remove, move up and down functions for post-status-form
- Refactored related parts
- Some improvements to flash component, namely - no longer has its own button for stopping, instead button now is in Attachment component.
Merge request reports
Activity
- Resolved by HJ
added 1 commit
- 44b741e2 - better attachments in uploading (grid layout)
added 6 commits
Toggle commit list- Resolved by Shpuld Shpludson
I'm not a fan of the super compressed notifications, thumbnail is borderline useless and text has less space too, I can't be the only one who gets long winded replies with an attachment with them.
- Resolved by Shpuld Shpludson
added 25 commits
- a0eaac22 - fix tests
- 2cfff1b8 - remove new options for style and separate line, now groups all chained
- 2182af40 - made the code responsible for showing unwritten mentions actually work
- add5921b - fix tests, add performance test (skipped, doesn't assert anything),
- 6c6df29e - support richcontent in polls
- 4c974f5c - richcontent support in polls, user cards and user profiles
- 97e86381 - remove old emoji added, everything emoji-bearing uses RichContent now
- 4465de52 - fixed mentions line again
- 530ac444 - removed useless code, review change, fixed bug with tall statuses
- 7d67e8f1 - remove obsolete tests
- 68b43231 - prevent infinite update loops
- f16658ad - fix tests
- 17d2eed0 - Merge branch 'better-still-emoji' into proper-attachments
- 6aa6f6f3 - fix console errors
- 8cc1ad67 - fix links sticking to mentionsline
- 5431d8fe - Merge branch 'better-still-emoji' into proper-attachments
- c8a7b6f4 - fix long posts double-fading in notifications
- 07c12ae1 - replace poll with an icon in notifications
- 299c00cf - fix video attachments in notifications not having pointer cursor
- 0087d33c - fix "+X more" sticking
- 777f6c01 - Merge branch 'better-still-emoji' into proper-attachments
- f5823a96 - add key attribute to make image refresh in media modal to give feedback
- 34d26546 - add media description into media modal
- 830a03a0 - inline description display
- 0507eb65 - ability to move attachments around when making a new post
Toggle commit listadded 2 commits
mentioned in issue #1097 (closed)
mentioned in issue pleroma#2780
mentioned in merge request pleroma!3535 (merged)
added 110 commits
-
49fe3341...182fcca5 - 108 commits from branch
develop
- c551e3e6 - Merge remote-tracking branch 'origin/develop' into proper-attachments
- 56de3d2f - fix too-many-attachments in notifications column
-
49fe3341...182fcca5 - 108 commits from branch
added 12 commits
-
56de3d2f...28ee5721 - 9 commits from branch
develop
- 94c37e8a - Merge remote-tracking branch 'origin/develop' into proper-attachments
- efd558f3 - Merge remote-tracking branch 'origin/develop' into proper-attachments
- d1f02221 - changelog
Toggle commit list-
56de3d2f...28ee5721 - 9 commits from branch
changed milestone to %Mentions/posts/notifications improvements
requested review from @shpuld
mentioned in commit ddee8bb6
mentioned in issue #1135 (closed)
mentioned in commit ilja/pleroma@6eca7b09
mentioned in commit ilja/pleroma@dc1dfba1
mentioned in commit ilja/pleroma@3c48e299
mentioned in commit ilja/pleroma@cd316d72
mentioned in commit ilja/pleroma@fb122bb2
mentioned in issue #865 (closed)