Skip to content
Snippets Groups Projects

Group emojis into packs in emoji picker

Merge request reports

Checking pipeline status.

Approval is optional

Merged by HJHJ 2 years ago (Sep 22, 2022 8:11am UTC)

Merge details

  • Changes merged into develop with 03b61f0a.
  • Deleted the source branch.

Pipeline #41922 passed

Pipeline passed for 03b61f0a on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • HJ
  • HJ
  • HJ
  • HJ
  • HJ
  • HJ
  • HJ
  • Maintainer

    Could you please comment the code more? It's very hard to understand what's going on and why certain things the way they are.

  • Maintainer

    Also i would really love to see how this works when connected to an instance with a fuckton of emoji, like https://fedi.absturztau.be/ main reason there are those buffers is because instances with too many emojis would take minutes to load because vue chokes rendering them all.

  • HJ mentioned in issue #1096 (closed)

    mentioned in issue #1096 (closed)

  • tusooa added 3 commits

    added 3 commits

    • 81937268 - Use lozad for lazy image loading
    • b84b2eab - Clean up legacy code in emoji picker
    • 70fbb36c - Fix scrol->highlight behaviour

    Compare with previous version

  • tusooa added 1 commit

    added 1 commit

    Compare with previous version

  • tusooa resolved all threads

    resolved all threads

  • tusooa added 5 commits

    added 5 commits

    • 6c6e0014 - Remove useless class `disabled` in emoji picker
    • 8b585e22 - Use StillImage for emoji group header
    • c96280bf - Fix vertical scrollbar of emoji picker header
    • 7fb26f11 - Fix sticker picker heading tab
    • f5e08a95 - Lazy-load emoji picker in post form

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading