Skip to content
Snippets Groups Projects

Pass file name of cropped avatar to form data

Merged Pass file name of cropped avatar to form data
iamtakingiteasy/pleroma-fe:eientei-pass-avatar-file-name into develop
All threads resolved!
Merged iamtakingiteasy requested to merge iamtakingiteasy/pleroma-fe:eientei-pass-avatar-file-name into develop
All threads resolved!

When avatar is cropped, all filename data including file extension is lost, leading to uploads like <hash>.blob that are causing mime issues in some setups.

This MR extends updateProfileImages with avatarName and passes original filename alongside with blob of cropped image to be specified in form data.

Edited by iamtakingiteasy

Merge request reports

Checking pipeline status.

Approval is optional

Merged by HJHJ 2 years ago (May 22, 2022 4:25pm UTC)

Merge details

  • Changes merged into develop with 48f97ebf.
  • Deleted the source branch.

Pipeline #39983 passed

Stage: lint
Stage: build
Stage: test
Stage: deploy

Pipeline passed for 48f97ebf on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • HJ
    HJ @hj ·
    Maintainer

    lgtm, just remove the console log

  • iamtakingiteasy added 1 commit

    added 1 commit

    • 29b084b4 - Pass file name of cropped avatar to form data

    Compare with previous version

  • HJ resolved all threads

    resolved all threads

  • HJ merged

    merged

  • HJ mentioned in commit 48f97ebf

    mentioned in commit 48f97ebf

    • Please register or sign in to reply