Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma-fe pleroma-fe
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 323
    • Issues 323
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 37
    • Merge requests 37
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleroma-fepleroma-fe
  • Merge requests
  • !1785

Specs for the gallery component

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Brian Underwood requested to merge cheerfulstoic/pleroma-fe:develop into develop Feb 07, 2023
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Changes

I'm looking into fixing potential bug with how attachments layout, but I wanted to start with adding some specs for the row function in the gallery component. When creating the specs I found some behavior that was weird to me, but it might be fine:

  • Grouping of items is limited to a maxPerRow of 3 only for attachments at the end of the list
  • If size: hide is set, no grouping happens and audio isn't set (I'm not sure what size: hide means, TBH)
  • grid: true causes nothing to be grouped

I'm submitting this merge request to verify that this is the expected behavior before moving forward.

Thanks!

Edited Feb 07, 2023 by Brian Underwood
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop