Custom emoji reaction support
Changes
- Adds support for custom emoji reacts in status buttons/popups and notifications (BE changes: pleroma!3845 (merged))
- Reuses status emoji picker, picker parametrized with custom emoji feature availability
-
Change in regards to akkoma implementation: no emoji button enlargement here.Added configurable reactions size scale.
Compatibility concern: there is no way to detect presence of changes on BE, with reused emoji picker users of older BE may be presented with selection of custom emojis that will be rejected as invalid by unchanged BE, if picked.
Merge request reports
Activity
mentioned in merge request pleroma!3845 (merged)
added 1 commit
- a3cf9ee6 - Hide custom emoji reactions when BE does not advertise pleroma_custom_emoji_reactions
added 1 commit
- ad8d265d - Hide custom emoji reactions when BE does not advertise pleroma_custom_emoji_reactions
added 1 commit
- 24fe40f7 - Hide custom emoji in reaction picker when BE does not advertise pleroma_custom_emoji_reactions
I personally prefer the vanilla emoji button size, but the setting certainly makes sense, I'll add one in this MR. Zooming as an alternative certainly can be convenient too, probably the tooltip with people reacted can be extended with larger emoji version, but I am not sure how to arrange it nicely, considering it's dynamic placement.
Added [advanced] config parameter to set the reactions scale. Akkoma uses scale factor of 2 (2.04 to be precise -- 1.25em <-> 2.55em).
Edited by iamtakingiteasyNoticed
IntegerSetting
is indeed only accepts integer values, which is probably not ideal for scaling factor. GeneralizedIntegerSetting
intoNumberSetting
usingparseFloat
with two wrappers -IntegerSetting
(maintains integer truncation) andFloatSetting
without truncation.Edited by iamtakingiteasy