Skip to content
Snippets Groups Projects

Custom emoji reaction support

Changes

  • Adds support for custom emoji reacts in status buttons/popups and notifications (BE changes: pleroma!3845 (merged))
  • Reuses status emoji picker, picker parametrized with custom emoji feature availability
  • Change in regards to akkoma implementation: no emoji button enlargement here. Added configurable reactions size scale.

Compatibility concern: there is no way to detect presence of changes on BE, with reused emoji picker users of older BE may be presented with selection of custom emojis that will be rejected as invalid by unchanged BE, if picked.

5daeaa007f67a028d83e8cd2ea137915

5e77a14681f07ffd5740b1008be41aab

Edited by iamtakingiteasy

Merge request reports

Checking pipeline status.

Approval is optional

Merged by HJHJ 1 year ago (Mar 20, 2023 8:31pm UTC)

Merge details

  • Changes merged into develop with fa532b1f.
  • Deleted the source branch.

Pipeline #44206 passed

Pipeline passed for fa532b1f on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • iamtakingiteasy changed title from WIP, BE changes not merged yet: Custom emoji reaction support to WIP: (no BE yet) Custom emoji reaction support

    changed title from WIP, BE changes not merged yet: Custom emoji reaction support to WIP: (no BE yet) Custom emoji reaction support

  • iamtakingiteasy changed title from WIP: (no BE yet) Custom emoji reaction support to WIP: (no BE merged yet) Custom emoji reaction support

    changed title from WIP: (no BE yet) Custom emoji reaction support to WIP: (no BE merged yet) Custom emoji reaction support

  • mentioned in merge request pleroma!3845 (merged)

  • added 1 commit

    • fbe1d778 - Allow custom emoji reactions

    Compare with previous version

  • iamtakingiteasy changed the description

    changed the description

  • Maintainer

    make it so that BE changes add new feature to instance features or something so we could detect and react accordingly.

  • added 1 commit

    • a3cf9ee6 - Hide custom emoji reactions when BE does not advertise pleroma_custom_emoji_reactions

    Compare with previous version

  • Added pleroma_custom_emoji_reactions in BE MR and corresponding property in EmojiPicker

  • added 1 commit

    • ad8d265d - Hide custom emoji reactions when BE does not advertise pleroma_custom_emoji_reactions

    Compare with previous version

  • added 1 commit

    • 24fe40f7 - Hide custom emoji in reaction picker when BE does not advertise pleroma_custom_emoji_reactions

    Compare with previous version

  • iamtakingiteasy marked this merge request as draft

    marked this merge request as draft

  • iamtakingiteasy changed title from WIP: (no BE merged yet) Custom emoji reaction support to Draft: (BE not merged yet) Custom emoji reaction support

    changed title from WIP: (no BE merged yet) Custom emoji reaction support to Draft: (BE not merged yet) Custom emoji reaction support

  • Backend part merged

  • iamtakingiteasy marked this merge request as ready

    marked this merge request as ready

  • iamtakingiteasy changed title from Draft: (BE not merged yet) Custom emoji reaction support to Custom emoji reaction support

    changed title from Draft: (BE not merged yet) Custom emoji reaction support to Custom emoji reaction support

  • iamtakingiteasy changed the description

    changed the description

  • iamtakingiteasy changed the description

    changed the description

      • Change in regards to akkoma implementation: no emoji button enlargement here.

      Not sure what Akkoma does but might be better to have the custom emojis be at the same size as they would inside posts. As right now they're the same size as unicode ones which is rather small.

    • Maintainer

      we can implement emoji size setting and zoom later, no biggie

    • I personally prefer the vanilla emoji button size, but the setting certainly makes sense, I'll add one in this MR. Zooming as an alternative certainly can be convenient too, probably the tooltip with people reacted can be extended with larger emoji version, but I am not sure how to arrange it nicely, considering it's dynamic placement.

    • Added [advanced] config parameter to set the reactions scale. Akkoma uses scale factor of 2 (2.04 to be precise -- 1.25em <-> 2.55em).

      Edited by iamtakingiteasy
    • Noticed IntegerSetting is indeed only accepts integer values, which is probably not ideal for scaling factor. Generalized IntegerSetting into NumberSetting using parseFloat with two wrappers - IntegerSetting (maintains integer truncation) and FloatSetting without truncation.

      Edited by iamtakingiteasy
    • Please register or sign in to reply
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading