Custom emoji reaction support

Changes

• Adds support for custom emoji reacts in status buttons/popups and notifications (BE changes: pleroma!3845 (merged))
• Reuses status emoji picker, picker parametrized with custom emoji feature availability
• Change in regards to akkoma implementation: no emoji button enlargement here. Added configurable reactions size scale.

Compatibility concern: there is no way to detect presence of changes on BE, with reused emoji picker users of older BE may be presented with selection of custom emojis that will be rejected as invalid by unchanged BE, if picked.

changed title from WIP, BE changes not merged yet: Custom emoji reaction support to WIP: (no BE yet) Custom emoji reaction support

changed title from WIP: (no BE yet) Custom emoji reaction support to WIP: (no BE merged yet) Custom emoji reaction support

mentioned in merge request pleroma!3845 (merged)

added 1 commit

• fbe1d778 - Allow custom emoji reactions

Compare with previous version

changed the description

make it so that BE changes add new feature to instance features or something so we could detect and react accordingly.

added 1 commit

• a3cf9ee6 - Hide custom emoji reactions when BE does not advertise pleroma_custom_emoji_reactions

Compare with previous version

Added pleroma_custom_emoji_reactions in BE MR and corresponding property in EmojiPicker

added 1 commit

• ad8d265d - Hide custom emoji reactions when BE does not advertise pleroma_custom_emoji_reactions

Compare with previous version

added 1 commit

• 24fe40f7 - Hide custom emoji in reaction picker when BE does not advertise pleroma_custom_emoji_reactions

Compare with previous version

marked this merge request as draft

changed title from WIP: (no BE merged yet) Custom emoji reaction support to Draft: (BE not merged yet) Custom emoji reaction support

Backend part merged

marked this merge request as ready

changed title from Draft: (BE not merged yet) Custom emoji reaction support to Custom emoji reaction support

changed the description

changed the description

• Change in regards to akkoma implementation: no emoji button enlargement here.

Not sure what Akkoma does but might be better to have the custom emojis be at the same size as they would inside posts. As right now they're the same size as unicode ones which is rather small.

we can implement emoji size setting and zoom later, no biggie

I personally prefer the vanilla emoji button size, but the setting certainly makes sense, I'll add one in this MR. Zooming as an alternative certainly can be convenient too, probably the tooltip with people reacted can be extended with larger emoji version, but I am not sure how to arrange it nicely, considering it's dynamic placement.

Added [advanced] config parameter to set the reactions scale. Akkoma uses scale factor of 2 (2.04 to be precise -- 1.25em <-> 2.55em).

Noticed IntegerSetting is indeed only accepts integer values, which is probably not ideal for scaling factor. Generalized IntegerSetting into NumberSetting using parseFloat with two wrappers - IntegerSetting (maintains integer truncation) and FloatSetting without truncation.

added 13 commits

• 24fe40f7...8abaf8fa - 10 commits from branch pleroma:develop
• 998aa8f7 - Allow custom emoji reactions
• 832019b2 - Hide custom emoji in reaction picker when BE does not advertise pleroma_custom_emoji_reactions
• a947ba16 - Allow custom emoji reactions: add option to scale reaction buttons

Compare with previous version

added 1 commit

• 3403f6a1 - Allow custom emoji reactions: add option to scale reaction buttons

Compare with previous version

changed the description

added 1 commit

• 53ca9ac5 - Generalize IntegerSetting into NumberSetting, add Integer/Float wrappers

Compare with previous version

added 1 commit

• 493120b5 - Generalize IntegerSetting into NumberSetting, add Integer/Float wrappers

Compare with previous version

Is there anything else that needs to be done/changed? Looks like some instances are already updating to the latest upstream and having issues with custom emoji being returned by API, but not rendered properly.

I'll look into this MR properly on monday, sorry for delay

custom emojis look like ass on older FEs but that's acceptable degradation

mentioned in commit fa532b1f

merged

mentioned in issue #796 (closed)