Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma-fe pleroma-fe
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 323
    • Issues 323
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 37
    • Merge requests 37
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleroma-fepleroma-fe
  • Merge requests
  • !1801

Fix user-profile route crash on pinned favorites timeline

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged iamtakingiteasy requested to merge iamtakingiteasy/pleroma-fe:fix-user-profile-route-crash into develop Mar 17, 2023
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

Currently getRouteTo in src/components/navigation/navigation_pins.js does not set name route parameter, which is required by user-profile route, leading to FE crashing early when favorites timeline is pinned. Reproduces in dev mode if after logging in as a user that has favorites timeline pinned page is refreshed.

Changes

  • routeTo logic needs to be common and so extracted to src/components/navigation/navigation.js
  • getRouteTo in navigation_pins.js and routeTo in navigation_entry.js implementations are replaced with calls to the extracted function.
Edited Mar 17, 2023 by iamtakingiteasy
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-user-profile-route-crash