Skip to content

Fix user-profile route crash on pinned favorites timeline

Currently getRouteTo in src/components/navigation/navigation_pins.js does not set name route parameter, which is required by user-profile route, leading to FE crashing early when favorites timeline is pinned. Reproduces in dev mode if after logging in as a user that has favorites timeline pinned page is refreshed.

Changes

  • routeTo logic needs to be common and so extracted to src/components/navigation/navigation.js
  • getRouteTo in navigation_pins.js and routeTo in navigation_entry.js implementations are replaced with calls to the extracted function.
Edited by iamtakingiteasy

Merge request reports

Loading