Accommodate scrobble URLs when present

When a scrobble URL is present, it makes the most recently played object a link. When there is no URL, it doesn't make it a link.

With URL:

Without URL:

The URL field is optional.

NOTE related backend PR is here: pleroma!3977 (merged)

mentioned in merge request pleroma!3977 (merged)

approved this merge request

Looks fine. A little bit offtopic but maybe we should limit how fresh the scrobble is in order to display it, otherwise we can end up in situation where last scrobble can be from multiple days ago and it just occupies space with no real value.

Yeah I thought about this, and the conclusion I came to was that maybe it should be a user setting somewhere. Which then raises the question of which user: the scrobbler or the viewer of the page? Or both somehow? I want to sleep on this one a bit more.

Should there be an option to just not have a limit?

yeah sure, but default should be at least within a week or so, my preference would be 1 day at most.

I'll put this in a separate PR for the sake of organization, but I'm already thinking about how to do it. It's probably just changing the function that checks if it's present at all by comparing the most recent to some time range, and making the "Hide scrobbles" option a drop down with a some options like "Always," "Never," and a couple time ranges like 1day/1week/1month/1year.

But I'm definitely going to sleep on that. In fact I think I'm going to go to sleep right now.

added 1 commit

• 94b4e210 - Accommodate scrobble URLs when present

Compare with previous version

@hj I did some cleanuup on this one to use the favicon of the domain name if it's present. You click the icon to go to the referenced url. It also repeats the code less. Also, since PleromaBE sanitizes the artist and title fields on their way out, I made them treat these as safe (so that it will show special characters instead of their unicode numbers).

It creates this visual effect:

One scrobble linking to Last.fm (marine@breastmilk.club) and one scrobble linking to Soundcloud (NEETzsche@iddqd.social)

Do you prefer I include these changes in this PR or put it in a future one?

future one. I'm really not sure about having other centralized services shown, so it's another topic.

Lol I didn't even think of that. I'll leave it be then

added 1 commit

• 632dd3b9 - Use #externalLink, not #url

Compare with previous version

added 1 commit

• 9cf307ca - Use #externalLink, not #url

Compare with previous version

added 1 commit

• 730351dc - Accommodate scrobble URLs when present

Compare with previous version

I removed the favicon stuff since my understanding is that hj doesn't like it.

resolved all threads

added 1 commit

• ce46b97c - Remove <img> for favicon

Compare with previous version

@hj Yeah I missed that, sorry.

enabled an automatic merge when the pipeline for ce46b97c succeeds

mentioned in commit 02fff5dd

merged