Skip to content
Snippets Groups Projects

Theme import & export

Merged elomatreb requested to merge elomatreb/pleroma-fe:feature/theme-export-import into develop

I took a basic shot at implementing #119 (closed).

WIP because I'm not sure about the styles for the buttons, they look rather weird (screenshot), but I wasn't sure how I should change the styles to conform to the rest of the site. Any feedback would be nice.

TODO:

  • Button styles
  • Feedback when an invalid file is selected (either not JSON or not a valid theme object)
Edited by elomatreb

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • elomatreb changed the description

    changed the description

  • elomatreb changed the description

    changed the description

  • elomatreb added 2 commits

    added 2 commits

    • 8f791938 - Unify button styles and use min-width
    • 2a87e291 - Add validation of the imported theme and the corresponding warning message

    Compare with previous version

  • elomatreb marked the checklist item Feedback when an invalid file is selected (either not JSON or not a valid theme object) as completed

    marked the checklist item Feedback when an invalid file is selected (either not JSON or not a valid theme object) as completed

  • elomatreb marked the checklist item Button styles as completed

    marked the checklist item Button styles as completed

  • elomatreb unmarked as a Work In Progress

    unmarked as a Work In Progress

  • elomatreb changed the description

    changed the description

  • Author Contributor

    I went ahead and unified the button styles into the global styles, it seemed to be duplicated across a lot of components needlessly. While doing that I also changed the static width that was set on them to a min-width, this keeps the look of them where the text is short enough just like they were before the change, but it allows them to get wider if the text is longer. This is probably helpful for localization, e.g. German tends to be long.

    I also added a version key to the exported theme files, this should prevent headaches if there is a more advanced version of this in the future.

  • merged

  • kaniini mentioned in commit 9982376f

    mentioned in commit 9982376f

  • Maintainer

    @elomatreb @kaniini @lambadalambda the whole "replace width with min-width" doesn't really do any good, tbh.

    image image

Please register or sign in to reply
Loading