Add settings for changing the visibility of replies in the timeline.

changed the description

added 1 commit

50b3bd22 - Remove old implementation of isReply.

added 1 commit

60b11532 - Fix indentation

Can anyone suggest a more reliable way to detect that we're not viewing a timeline and have instead clicked on a post? currently this doesn't seem to work reliably.

marked as a Work In Progress

cc @hj

added 1 commit

da962948 - Don't hide replies when inConversation.

Compare with previous version

unmarked as a Work In Progress

okay, that was quite obvious. seems to be fixed.

merged

mentioned in commit 55650ff7

currently this also hides replies in user TL (i.e. when viewing a user profile), but that needs a separate control for "posts/with-replies/media" anyway
something i need to check if posts that are "replies" (ie they have "in-reply-to" field) but without mentions are shown or not. It could break some chain posts, when user is replying to their own post.
need to check retweets of replies.
need to know if non-replies still work, i.e. someone just mentioning some users in their post like hey guys @hj is an asshole

i'm gonna qa and possibly fix this stuff in another tweaks-n-fixes MR.

@hj

currently this also hides replies in user TL (i.e. when viewing a user profile), but that needs a separate control for "posts/with-replies/media" anyway

yes.

something i need to check if posts that are "replies" (ie they have "in-reply-to" field) but without mentions are shown or not. It could break some chain posts, when user is replying to their own post.

yes, that's accounted for in the code. notice that the last line is this.status.attentions.length > 0

need to check retweets of replies.

notice where it checks activity_type === 'repeat'

need to know if non-replies still work, i.e. someone just mentioning some users in their post like hey guys @hj is an asshole

those posts don't have in_reply_to_status_id set, so they don't count as replies. however, when the post's scope is set to private, it will share this trait if it's a reply to another private post by a user we're not following. so there needs to be a way to tell those apart.

speaking of code i'd replace most of that with something like a one or two boolean expressions.

seeing something equivalent if (true) { return false } just makes me cry
seeing function with more than 3 return statements makes me cry

i don't think we need to worry about private post and just always show them because we won't see them if we are not mentioned anyway

you currently do see replies with private/followers-only scope if you're not mentioned

you mean you see other people's DMs? Nice.

no, 'private' (followers-only) scope as opposed to 'direct' scope.

what's this project's standard for indenting continuations of overly-long lines anyway

followers-only DO have in-reply-to-status-id set IIRC

Add settings for changing the visibility of replies in the timeline.

Merge request reports

Activity