Registration form: Client side validation + better display of server validation errors

Fixes validation errors during registration, previously errors from BE haven't been parsed and displayed to user as json

Before

After

Screen_Recording_2018-12-05_at_19.32.37

added 1 commit

• 70c4faa0 - Humanize validation errors returned on registration

Compare with previous version

Probably we also need I18n on BE side for such errors, what do you think?

I don't think BE needs localization. Without it it's easier to determine error by string matching.

Well it's better than what we have right now, just two things:

1. I'd do string comparison, just in case BE sends something more technical that's better to rephrase. Also that would allow i18n on FE.
2. I'd group fields so it would say "Password, username, email and confirmation cannot be blank" instead of robot-like sentences.
3. Probably real solution is to add form validation on FE.

1 and 2 are good points, I'll change the code to group messages by the validation rule, not by the field.

About 3, don't think we can replace BE validation with FE only. Client-side validation is a nice thing to have since it gives instant feedback to our user. It's not reliable though and always can be bypassed so we would still need some way to show errors from BE validation.

I think ability to bypass it isn't as important in this case tho. Ability to bypass usually referred to when people do validation just client-side.

added 9 commits

• 70c4faa0...3fa9b391 - 6 commits from branch pleroma:develop
• 822559af - Humanize validation errors returned on registration
• 02e000b5 - Use Array.reduce instead of lodash.reduce
• 00293137 - Add client validation for registration form

Compare with previous version

marked as a Work In Progress

changed the description

added 1 commit

• 2b903f79 - Fix broken ToS link. Fix linter errors

Compare with previous version

Client side validation example

Things left:

• I18n for validation messages
• Validate that password == password_confirmation on client
• Better styling

added 2 commits

• f9ff839b - Better styling for client-side validation. Add I18n for validation errors.
• 91a72d51 - Validate name presence on client-side as well

Compare with previous version

unmarked as a Work In Progress

changed title from WIP: Humanize validation errors returned on registration to Registration form: Client side validation + better display of server validation errors

changed the description

@hj added client-side validation with i18n, refactored registration component a bit as well, let me know your thoughs