add service worker and push notifications

Add configuration disable push notifications.

Also, how does it work with already existing non-push notifications?

Also, how does it work with already existing non-push notifications?

Non-push notifications have priority over push. Push notifications show only if there are no open tabs with Pleroma.

added 1 commit

• ebe2a951 - improve web push notifications

Compare with previous version

added 1 commit

• bbae2e10 - Add configuration to enable/disable web push notifications

Compare with previous version

added 1 commit

• 264da19f - fix typo

Compare with previous version

added 1 commit

• 07f1b852 - add subscribe module and fix race condition

Compare with previous version

added 2 commits

• a85d128d - Revert "add subscribe module and fix race condition"
• 11716a7a - second attempt to add subscribe module and fix race condition

Compare with previous version

How does this work overall? I know the backend pushes the messages with http, but where does it push too?

@lambadalambda as far as i know, JS asks browser to do some black magic shit, which registers some shit at browser's push service which i can only assume tells the backend to start pushing stuff to it?

https://blog.mozilla.org/services/2016/08/23/sending-vapid-identified-webpush-notifications-via-mozillas-push-service/ has an explanation, and yes, it gets a magic browser-vendor specific url.

added 1 commit

• 73b17d70 - improve push notifications code

Compare with previous version

added 1 commit

• ee70ec4c - fix race condition

Compare with previous version

Still no configuration to disable web push. Only reference to webPushNotifications which isn't defined anywhere else, no UI changes.

Oh and also merge conflicts

Still no configuration to disable web push. Only reference to webPushNotifications which isn't defined anywhere else, no UI changes.

I'm sorry, I didn't know this is also a requirement. Could you please list all the requirements that we had not touched yet in previous discussions, if there are any.

I already asked for this before: !404 (comment 9142)

And given that you've added webPushNotifications i assume you started working on it but not quite finished.

No more requirements.

maybe i hit my head when i was typing that but just in case:

Make web push configurable. Some people might want to have notifications ONLY when website is open.

added 1 commit

• 02c0e157 - add checkbox to disable web push

Compare with previous version

added 136 commits

• 02c0e157...e443716b - 134 commits from branch pleroma:develop
• b3455649 - improve notification subscription
• a8521fc8 - Merge commit 'e443716b' into feature/push-subscriptions

Compare with previous version

please review

That'll do for now. Although I fear that config option won't actually work for disabling push notifications, but we'll see when entire stack works in real life situation.

resolved all discussions

merged

mentioned in commit 8e4777cc

✘ http://eslint.org/docs/rules/no-undef 'data' is not defined
/home/lambda/projects/pleroma/code/pleroma-fe/src/main.js:64:69 store.dispatch('setOption', { name: 'nsfwCensorImage', value: data['nsfwCensorImage'] })

As far as I can tell, this should crash.

And it does.

@lambadalambda hey buddy i think you got the wrong door, nsfwCensorImage is two blocks down