Skip to content
Snippets Groups Projects

Improved user profile display

Merged HJ requested to merge fix_empty_profiles into develop
  • Fixed fetchUser incorrectly calling addNewUsers with an object instead of an array
  • Made addNewUsers also store local instance users in usersObject by screen_name in addition to id - this is needed for links like /users/username to work
  • Since MR turned out to be much smaller than I anticipated I've also added small thing - now it displays placeholder until user profile is loaded
    image

Closes #82 (closed)

Edited by HJ

Merge request reports

Pipeline #5291 passed

Pipeline passed for fa7c3c20 on fix_empty_profiles

Approval is optional

Merged by Shpuld ShpludsonShpuld Shpludson 6 years ago (Dec 13, 2018 2:42pm UTC)

Merge details

Pipeline #5296 passed

Pipeline passed for c824d253 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading