Skip to content
Snippets Groups Projects

remove unneeded numbered variables who_to_follow

Merged remove unneeded numbered variables who_to_follow
FloatingGhost/pleroma-fe:refactor-recommendations into develop
All threads resolved!
Merged Sadposter requested to merge FloatingGhost/pleroma-fe:refactor-recommendations into develop
All threads resolved!

The previous implementation of the who to follow panel used variables like img1, name1 and so on

this is a standard use-case for an array

this PR refactors the component along those lines

Merge request reports

Pipeline #5705 passed

Stage: lint
Stage: build
Stage: test

Pipeline passed for ed2393c9 on FloatingGhost:refactor-recommendations

Approval is optional

Merged by HJHJ 6 years ago (Dec 25, 2018 2:35am UTC)

Merge details

  • Changes merged into develop with a80c8fd2.
  • Did not delete the source branch.

Pipeline #5706 passed

Stage: lint
Stage: build
Stage: test

Pipeline passed for a80c8fd2 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • HJ
  • HJ
  • Sadposter added 1 commit

    added 1 commit

    • ed2393c9 - fix inconsistencies within who_to_follow_panel

    Compare with previous version

  • HJ resolved all discussions

    resolved all discussions

  • HJ
    HJ @hj ·
    Maintainer

    looks good. merging or you have more changes to add?

  • Sadposter
    Sadposter @FloatingGhost ·
    Author Contributor

    I think it's good to go

  • HJ merged

    merged

  • HJ mentioned in commit a80c8fd2

    mentioned in commit a80c8fd2

  • Hakaba Hitoyo mentioned in merge request !441 (merged)

    mentioned in merge request !441 (merged)

    • Please register or sign in to reply