Skip to content
Snippets Groups Projects

scopeCopy → true by default

Merged nia requested to merge scarlett/pleroma-fe:scope-copy-default into develop

The current default is a regression and a surprise when updating.

(or might just be completely broken since the setting doesn't seem to be honored anyway)

Edited by nia

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • better also change the default in instance.js

  • nia changed the description

    changed the description

  • Maintainer

    The current default is a regression and a surprise when updating.

    i find scope copying to be causing much more troubles when it's on than when it's off.

    (or might just be completely broken since the setting doesn't seem to be honored anyway)

    i already fixed that.

  • Maintainer

    you could also change it in BE's config.exs i suppose

  • This is a privacy related setting that people rely on to keep their messages 'private'. I sure would be shocked when my replies to DMs suddenly were public. In what way are they 'more trouble'?

  • btw, looking at https://git.pleroma.social/pleroma/pleroma/blob/develop/config/config.exs#L148, it seems we DO set it to true in the BE. @scarlett are you running a custom FE and this hit you because of that?

  • Maintainer

    probably just running outdated BE, as even custom FE wouldn't help. static/config.json is nearly worthless these days and kinda could be just removed altogether.

  • Maintainer

    DMs' scopes are ALWAYS copied. It's even stated so in UI. Do i need to make it 48pt in UI for better visibility? image image it only affects unlisted/followers-only posts, which are problematic. DMs' scopes are SO MUCH always copied, they were even copied when setting was broken and not honored.

    Defaulting it to false solves several problems:

    1. someone has their default to "unlisted" because they are running an instance and don't want to make it look like they're are the only one there, replying to them would make your own replies unlisted, which might be undesireable
    2. not sure put i think the inverse of above is also applicable, but if you keep your posts followers-only, replying to a public post would make your reply a public post.
    3. same as (1) but followers-only, and followers-only posts are just plain cancer altogether, or rather an STD-cancer, and I don't want it to spread.

    Overall, i feel like user's posts should ALWAYS be the same scope as user's default, except for DMs.

  • I don't particularly care what the default is, but the setting should never change for a user when updating (regardless of if the user was using default or the other), I hope this isn't what happened

  • Maintainer

    @shpuld setting would change if user didn't touch the setting at all, at least that's how it is right now.

  • what if user never touched the setting because they thought it was good already? it shouldn't change like that either

  • Maintainer

    Made an issue about it so that wodn't pollute someone's MR with flood #245 (closed)

    It's not an easy one so please read the description, i've stated my point there.

  • I checked on kawen.space and my account had scope copying disabled (while still saying 'default: true'). The BE config also returned true for it. It seems like it was somehow set to false? Was this a bug we had for a while?

    On a newly setup instance I didn't encounter any problems with scope copying, it worked as expected.

  • Maintainer

    @lambadalambda yes there was a bug that made it act as if it's false because it's undefined, not inheriting the instance setting. It was fixed in !429 (merged)

  • HJ merged

    merged

  • HJ mentioned in commit a974d2ab

    mentioned in commit a974d2ab

  • Maintainer

    i've merged it but it doesn't change anything, really because it's already in BE.

  • Maintainer

    it's "just thought that matters" i guess.

  • ah, i see! thank you!

Please register or sign in to reply
Loading