Restore old routes, enable user route as fallback.

Will add a PR to reserve some routes on the backend.

pleroma!594 (merged)

this doesn't change profile link generation, so if user has username that is reserved path it will break completely, unable to even view profile in some cases

i'll check what i can do about that. i've reserved all the routes and some additional stuff in the BE MR.

• make reserved routes admin expandable, so, for example i could add /ngs to it beause i have it as a route for ngnix to serve some static files even if BE is down.
• make BE expose the said routes to FE so that FE can check for collisions too
• make FE check if route will go to a user profile page route instead of anything else, similar to what test does.
• [optional] contemplate on stupidity of the whole situation and think about adding more reserved names and breaking some links.

added 1 commit

• f35dbaf0 - Treat reserved users like external users in the frontend.

Compare with previous version

@hj implemented that

mentioned in issue #246 (closed)

you can use restrictedNicknames.includes(screenName) instead of lodash.

It's more complicated than you think! The more I look into this code the more i feel like unit tests are neccesary.

• 'external-user-profile' and 'user-profile' are essentially same route URL-wise, with few gotchas that make me wonder how vue will react.
• 'external-user-profile' uses id param and will probably break if you give it name param
• 'user-profile' uses name param and has both optional part and extreme collisions - will { name: 'settings' } generate /settings or /user/settings?

something must be done at least. Maybe change name to id for both routes to avoid superfluous branching?

To me it looks fairly safe and I would be ready to merge, but the concerns are valid. I'll never say no to more unit tests at least. Maybe the name param in user profile should be called userName instead?

This works as expected, for people on the restricted list, it will be generating the external style (domain.com/users/id), for normal nicknames it will generate domain.com/user names. The matching works from top to bottom. Refresh works normally as well.

some nitpickings, but otherwise looks good. I'd probably check how vue generates routes for colliding routes (see !440 (comment 11639)) and also maybe keep FE-specific list of reserved nicknames for BE (devs) to be aware of, but that's stuff for the future.

I think this whole component could use some refactoring, it's kinda hard to understand how it even branches between the different variants. I'll merge this now and refactor it right after.

merged

mentioned in commit 1555a5fe