Skip to content
Snippets Groups Projects

Fixed JS error in tag page

Merged Edijs Bov requested to merge edijs/pleroma-fe:fix/js-error-in-tag-page into develop
1 unresolved thread

Merge request reports

Pipeline #7249 passed

Pipeline passed for 0dc7c45f on edijs:fix/js-error-in-tag-page

Approval is optional

Merged by Shpuld ShpludsonShpuld Shpludson 6 years ago (Feb 9, 2019 6:56am UTC)

Merge details

Pipeline #7306 passed

Pipeline passed for 5296d413 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
34 34 }
35 35 },
36 36 actions: {
37 startFetching (store, timeline) {
37 startFetching (store, payload) {
  • Author Guest

    @shpuld I also don't think passing an array was good idea. But I didn't modify it to minimize the code changes. And because former developer used the timeline variable for multi-purpose, I thought payload was an appropriate name.

  • while it's more changes to change all users of startFetching to use an object, I think it would be worth it.

  • Edijs Bov added 1 commit

    added 1 commit

    Compare with previous version

  • Author Guest

    @shpuld , @hj Please review this.

  • it looks so much nicer to me now!

  • mentioned in commit 5296d413

  • Please register or sign in to reply
    Loading