Skip to content
Snippets Groups Projects

#340 Fix UI of followers list

Closed #340 Fix UI of followers list
1 unresolved thread
Closed Edijs Bov requested to merge edijs/pleroma-fe:fix/followers-ui into develop
1 unresolved thread

Issue #343 (closed) #340 (closed)

Here is the screenshots what it looks like

Screen_Shot_2019-02-12_at_9.01.51_AM

@shpuld I didn't update Stop following in this PR because idk how to translate other i18n words.

Edited by Edijs Bov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Shpuld Shpludson
  • Shpuld Shpludson
  • Shpuld Shpludson
  • Edijs Bov added 1 commit

    added 1 commit

    Compare with previous version

  • Edijs Bov resolved all discussions

    resolved all discussions

  • Edijs Bov changed the description

    changed the description

  • Edijs Bov changed title from Fix UI of followers list to #340 Fix UI of followers list

    changed title from Fix UI of followers list to #340 Fix UI of followers list

  • Looks much nicer already! I'll have another look after we have a stable master!

  • I was checking this out locally as it fixes some things I'd really want in the stable master, but I found out one problem with it, expanding a profile in the list is a bit broken

    follows_broken

    • Double comment to make this into an unresolved:

      • size/position of the expanded user card isn't correct
      • there's some pixel offset between the avatar top and expanded user card top
    • Checked on develop, the "stop following" shouldn't also be there when the card is expanded, as the card already has a button for unfollowing

    • Maintainer

      Instead of expanding the card there why not have it just open the profile? The expansion of user profile cards is a really strange UX decision that doesn't feel natural IMO. This one isn't even a timeline that you'd be leaving from.

    • it might seem strange but once you're used to it, you don't really want to give it up either. it's very handy to be able to see the important stuff about other profiles without doing additional navigation.

    • Please register or sign in to reply
  • Shpuld Shpludson mentioned in merge request !590 (merged)

    mentioned in merge request !590 (merged)

  • Took over and made a new MR off this code with some improvements at !590 (merged)

    I'm closing this one to not have two MR's with the same changes

  • Please register or sign in to reply
    Loading