Use self-background image on someone's profile

Closes #366

added 1 commit

• 97ac5783 - Remove js console log

Compare with previous version

code refactoring

resolved all discussions

added 1 commit

• 2c4d1af3 - Address method name meaningful

Compare with previous version

changed the description

Looks good to me

This wouldn't be enough to close that issue which is about entire themes (not in backend yet so not possible to do yet)

This doesn't do the instance theme but it does the background image which is a huge improvement for some users. Does it make merge this part while we figure out how or if it's appropriate to do entire theme changes for a user profile?

@shpuld entire theme settings are being saved in user's browser localstorage, not backend.

Wait, this MR is only about displaying the background-image of a remote-user, not theme. Will that still come?

Right, Pleroma-FE can't fetch the theme of remote-user from backend because theme configs are stored in web browser localstorage.

there's still no setting to expose or not your background image, we need that first

Is that something we want to be user configurable? I wouldn't consider it a privacy issue, and as a user I would already expect a background customization to be viewable by all users who visit my profile much like how they can see my banner image.

Just want to make sure we don't go too far down the path of a thousand configuration knobs that only make users more confused when they look at the settings panels.

yes. I tune my instance (well, tuned it at some point, it's a bit broken now) to have a certain style and aesthetic to it. But I myself use a bit more easy-on-eyes theme and whatever not-really-matching wallpaper. I'd still want people to see instance's default theme/wallpaper when they visit my profile.

Ideally I'd love to see separate themes/background "what people see my profile as" and "how I see interface".

Understood. Thanks for sharing. I am just being cautious to make sure we are mindful of the boundary between configurability and overkill.

We can tackle that as well if you open an issue and describe how you'd like that done.

the boundary between configurability and overkill.

t. made themes v2

:DDDDDDDDDD

I don't think having wallpapers show up without "permission" is that bad, considering qvitter and twitter already displayed them to visitors so it's kinda to be expected, it's set together with 2 other images that are also public, and the url to the wallpaper is already sent over so it's not "private" in any real way. It would still be better if it was a part of a bigger "feature" that is worth announcing and caring about, so people can form their opinions about it before it happens, it's not a thing we'd want to "sneak in" silently.

I know I'd be super interested in seeing how others configure their own stuff and I think having user profiles automatically use the theme of that user would be a killer feature. it can't be done right now but it could be done if we want it. I'd really hate it if a big feature would be disabled by default as well, we already hide so many features.

can we make this feature as optional? add this option as user settings.

closed