Skip to content
Snippets Groups Projects

Keyboard binding

Merged Keyboard binding
edijs/pleroma-fe:keyboard-binding into develop
1 unresolved thread
Merged Edijs Bov requested to merge edijs/pleroma-fe:keyboard-binding into develop
1 unresolved thread

Closes #369 (closed)

Pressing . keyboard button will show new status.

This is prototype of keyboard binding feature (#148).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/components/timeline/timeline.js
67 67 document.addEventListener('visibilitychange', this.handleVisibilityChange, false)
68 68 this.unfocused = document.hidden
69 69 }
70 window.addEventListener('keydown', this.handleShortKey)
  • Edijs Bov
    Edijs Bov @edijs ·
    Author Guest

    I can't reproduce your issue on my end. Are these errors related to the PR?

  • Tae Hoon
    Tae Hoon @tae ·
    Contributor

    Yes, since I get the errors whenever press down on . key.

  • HJ
    HJ @hj ·
    Maintainer

    error occurs because you need to validate if there's any new statuses to show. Since there's no statuses at all in TL, it breaks.

    Or something like that.

  • Edijs Bov
    Edijs Bov @edijs ·
    Author Guest

    Got it, let me fix it. Thanks @hj

  • Edijs Bov added 1 commit

    added 1 commit

    • d032ce27 - Validate if there are any new status to show

    Compare with previous version

  • Shpuld Shpludson
    Shpuld Shpludson @shpuld ·
    Maintainer

    feels a bit scary putting non-configurable always-on hotkeys that are being listened to at all times in the application. we currently do stuff like arrows, tab, esc, but only in very specific situations (text input, or with a modal open). I do agree that hotkeys are very useful and we'd want them, but we also don't want to step on the shoes of people who use browser plugins for keyboard navigation by not having ours configurable.

  • Edijs Bov
    Edijs Bov @edijs ·
    Author Guest

    Are we going to add this feature? #148

    Edited by Edijs Bov
  • HJ
    HJ @hj ·
    Maintainer

    I agree that keybindings should be configurable. People using keyboard navigation (Sakakey, VimFX (yeah, rip)) can temporarily disable them. At least I do with websites with decent hotkeys (TT-RSS). Websites' hotkeys could interfere with extensions but I think most of them can suppress websites' hotkeys, at least sakakey does. Sakakey also fails to enter "ignore" mode correctly and still suppresses esc making it impossible to exit lighbox without putting site to blacklist.

  • HJ
    HJ @hj ·
    Maintainer

    I don't think keybinds should necessarily be configurable at this early stage, but we do need to add them asap since we're adding them, so making some sort of framework/reusable base for them would be great.

  • Shpuld Shpludson
    Shpuld Shpludson @shpuld ·
    Maintainer

    I'll take your word for it that they won't get in the way of different plugins (that I don't use) and we're fine with this for now.

  • Shpuld Shpludson mentioned in commit 24f3770f

    mentioned in commit 24f3770f

  • Shpuld Shpludson merged

    merged

  • tastytea mentioned in issue #432 (closed)

    mentioned in issue #432 (closed)

    • Please register or sign in to reply