Skip to content
Snippets Groups Projects

Notifications tab

Closed Notifications tab
edijs/pleroma-fe:notifications-tab into develop
2 unresolved threads
Closed Edijs Bov requested to merge edijs/pleroma-fe:notifications-tab into develop
2 unresolved threads

Closes #401 and #400 (closed)

Edited by Edijs Bov

Merge request reports

Pipeline #9205 passed

Stage: lint
Stage: build
Stage: test

Pipeline passed for a69144d1 on edijs:notifications-tab

Approval is optional

Closed by Shpuld ShpludsonShpuld Shpludson 5 years ago (Apr 9, 2019 6:07pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/modules/config.js
25 25 likes: true,
26 26 repeats: true
27 27 },
28 webPushNotifications: false,
  • HJ
  • HJ
    HJ @hj ·
    Maintainer
    1. Does not resolve #401:
    • No granular control over web-push
    • Granular control over notifications still affects everything, not just notifications panel. See also: #232
    1. Adding admin control is good, but I'd love to see that option grayed out of web push notifications are disabled on BE if it's even possible.
    Edited by HJ
  • HJ mentioned in issue #400 (closed)

    mentioned in issue #400 (closed)

  • Edijs Bov added 3 commits

    added 3 commits

    • 3616f282 - Set webPushNotifications undefined in user config
    • 20981536 - Keep statuses in notifications column
    • 3e409c46 - Gray out of web push notification option if disabled in instance setting

    Compare with previous version

  • Edijs Bov marked as a Work In Progress

    marked as a Work In Progress

  • Edijs Bov
    Edijs Bov @edijs ·
    Author Guest

    @feld , @hj do you think this notification control table is correct? ^

  • HJ
    HJ @hj ·
    Maintainer

    what "always/optional" means?

  • Edijs Bov
    Edijs Bov @edijs ·
    Author Guest

    Mention will Always be visible in notifications column regardless of mention option is toggled in settings panel for example.

    Optional means the status notification will be displayed if the option is active in settings panel.

  • Edijs Bov added 1 commit

    added 1 commit

    • c7dd36ec - Make granular notification options

    Compare with previous version

  • Edijs Bov added 77 commits

    added 77 commits

    Compare with previous version

  • Edijs Bov unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Shpuld Shpludson
    Shpuld Shpludson @shpuld started a thread on an old version of the diff
    • src/services/notification_utils/notification_utils.js
    2 2
    3 3 export const notificationsFromStore = store => store.state.statuses.notifications.data
    4 4
    5 export const visibleTypes = store => ([
    6 store.state.config.notificationVisibility.likes && 'like',
    7 store.state.config.notificationVisibility.mentions && 'mention',
    8 store.state.config.notificationVisibility.repeats && 'repeat',
    9 store.state.config.notificationVisibility.follows && 'follow'
    10 ].filter(_ => _))
  • HJ
    HJ @hj ·
    Maintainer

    also i still don't understand the optional/always means, can't it be less confusing? also no need for auto-read since it's just an example of possible new feature

  • Edijs Bov
    Edijs Bov @edijs ·
    Author Guest

    You can ignore it.

  • Edijs Bov added 1 commit

    added 1 commit

    • 0fe76407 - Added optional tick boxes for notification panel visibility

    Compare with previous version

  • Edijs Bov added 1 commit

    added 1 commit

    • 96fd36f3 - Fix unit tests for notifications util

    Compare with previous version

  • Edijs Bov
    Edijs Bov @edijs ·
    Author Guest

    @hj please check again

  • Edijs Bov added 64 commits

    added 64 commits

    Compare with previous version

  • Edijs Bov added 48 commits

    added 48 commits

    Compare with previous version

  • Shpuld Shpludson closed

    closed

    • Please register or sign in to reply