Skip to content
Snippets Groups Projects

Initial work on deprecating scopeModesEnabled in favor of minimalScopeMode

Merged Initial work on deprecating scopeModesEnabled in favor of minimalScopeMode
minimal-scopes-mode into develop
2 unresolved threads
Merged HJ requested to merge minimal-scopes-mode into develop
2 unresolved threads

see also: #147 (closed) (fixes last two checkboxes there)

Edited by HJ

Merge request reports

Pipeline #9687 passed

Stage: lint
Stage: build
Stage: test

Pipeline passed for 07927328 on minimal-scopes-mode

Approval is optional

Merged by HJHJ 5 years ago (Apr 1, 2019 7:32pm UTC)

Merge details

Pipeline #9811 passed

Stage: lint
Stage: build
Stage: test

Pipeline passed for 3c293152 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Shpuld Shpludson
  • Shpuld Shpludson
    Shpuld Shpludson @shpuld ·
    Maintainer

    Looks good to me overall, a welcome change!

  • Shpuld Shpludson
    Shpuld Shpludson @shpuld ·
    Maintainer

    what's the status of this? should it be merged already or what?

  • HJ
    HJ @hj ·
    Author Maintainer

    i wanted to do changes you mentioned but got busy with mastoapi. If you're ok with it, we can merge it as is, been working fine on sgsgb

  • Shpuld Shpludson
    Shpuld Shpludson @shpuld ·
    Maintainer

    I'll test it briefly and merge if I have nothing to complain about it, to me it seems something we'd want in even if it's not completely done

  • HJ added 1 commit

    added 1 commit

    Compare with previous version

  • HJ added 1 commit

    added 1 commit

    Compare with previous version

  • HJ added 264 commits

    added 264 commits

    Compare with previous version

  • HJ added 1 commit

    added 1 commit

    Compare with previous version

  • HJ added 2 commits

    added 2 commits

    Compare with previous version

  • HJ resolved all discussions

    resolved all discussions

  • Shpuld Shpludson
    Shpuld Shpludson @shpuld started a thread on the diff
    • BREAKING_CHANGES.md 0 → 100644
    1 # v1.0
    2 ## Removed features/radically changed behavior
    3 ### minimalScopesMode
    4 As of !633, `scopeOptions` is no longer available and instead is changed for `minimalScopesMode` (default: `false`)
    5
    6 Reasoning is that scopeOptions option originally existed mostly as a backwards-compatibility with GNU Social which only had `public` scope available and using scope selector would''t work. Since at some point we dropped GNU Social support, this option was mostly a nuisance (being default `false`'), however some people think scopes are an annoyance to a certain degree and want as less of that feature as possible.
    7
    8 Solution - to only show minimal set among: *Direct*, *User default* and *Scope of post replying to*. This also makes it impossible to reply to a DM with a non-DM post from UI.
  • Shpuld Shpludson
    Shpuld Shpludson @shpuld started a thread on the diff
    • src/components/post_status_form/post_status_form.vue
    48 48 </label>
    49 49 </span>
    50 50
    51 <div v-if="scopeOptionsEnabled">
    52 <i v-on:click="changeVis('direct')" class="icon-mail-alt" :class="vis.direct" :title="$t('post_status.scope.direct')"></i>
    53 <i v-on:click="changeVis('private')" class="icon-lock" :class="vis.private" :title="$t('post_status.scope.private')"></i>
    54 <i v-on:click="changeVis('unlisted')" class="icon-lock-open-alt" :class="vis.unlisted" :title="$t('post_status.scope.unlisted')"></i>
    55 <i v-on:click="changeVis('public')" class="icon-globe" :class="vis.public" :title="$t('post_status.scope.public')"></i>
    56 </div>
    51 <scope-selector
    52 :showAll="showAllScopes"
    53 :userDefault="userDefaultScope"
    • Shpuld Shpludson
      Shpuld Shpludson @shpuld ·
      Maintainer

      Is there value from having this as a prop when it's just read from the state and passed forward?

    • HJ
      HJ @hj ·
      Author Maintainer

      I don't really like the idea of small components getting input from some second source, it makes them less testable, kinda.

    • Please register or sign in to reply
  • Shpuld Shpludson
    Shpuld Shpludson @shpuld ·
    Maintainer

    Seems to work correct and the points I raised are very minor, feel free to merge

  • HJ mentioned in commit 3c293152

    mentioned in commit 3c293152

  • HJ merged

    merged

    • Please register or sign in to reply