Skip to content
Snippets Groups Projects

Re-do UserCardContent Component CSS

Merged Tae Hoon requested to merge tae/pleroma-fe:420-redo-user-card-content into develop
All threads resolved!

Closes #420 (closed)

Now, the component accepts two additional style-modifier props - bordered and rounded.

Screenshots:

  • User Profile / User Panel

Screenshot_at_Mar_05_11-00-52

  • Timeline / Notifications

Screenshot_at_Mar_05_11-04-28

  • Following / Followers

Screenshot_at_Mar_05_11-05-41

  • Side Drawer

Screenshot_at_Mar_05_11-06-48

Edited by Tae Hoon

Merge request reports

Pipeline #8615 passed

Pipeline passed for 5f51fe89 on tae:420-redo-user-card-content

Approval is optional

Merged by Shpuld ShpludsonShpuld Shpludson 6 years ago (Mar 7, 2019 4:38pm UTC)

Merge details

Pipeline #8688 passed

Pipeline passed for 09736691 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • HJ
  • Maintainer

    i feel like the whole component could be renamed into UserCard instead of UserCardContent at this point. Not sure how many conflicts this will entail

  • Tae Hoon added 1 commit

    added 1 commit

    • 43c52cb9 - Update modifier class notation

    Compare with previous version

  • Author Contributor

    @hj Yes, I agree. However, we also have BasicUserCard component used in the user lists (followers, friends, blocks, etc). This should be renamed as well to avoid confusion.

    any thoughts? cc @shpuld

  • I agree with the rename suggestion. Overall some things are cleaned up and the changes that deviate from current style (as if we had any consistent style lol) aren't offensive to me.

  • Maintainer

    BasicUserCard as well as its numerous children aren't really cards per se...

  • Tae Hoon added 2 commits

    added 2 commits

    • baf603a5 - Update block class name of BasicUserCard component
    • 7bceabb5 - Rename UserCardContent to UserCard

    Compare with previous version

  • Tae Hoon resolved all discussions

    resolved all discussions

  • Author Contributor

    updated.

  • Tae Hoon added 1 commit

    added 1 commit

    Compare with previous version

  • HJ
  • HJ
  • HJ
  • Tae Hoon added 2 commits

    added 2 commits

    Compare with previous version

  • Tae Hoon resolved all discussions

    resolved all discussions

  • Author Contributor

    Updated.

  • mentioned in commit 09736691

  • Please register or sign in to reply
    Loading