Fetching convos via MastoAPI
- Conversations now store which statuses they need to display instead of attempting to find statuses by
statusnet_conversation_id
(which mastoapi doesn't have)
Since MastoAPI doesn't support convesration id, we can't use current flow, and to be honest it's kinda slow.
Old conversation flow:
- fetch relevant statuses
- show all statuses that we know of that have same
statusnet_conversation_id
, this will update when new statuses are fetched This essentially O(n) since it's basically searching entireallStatuses
for which statuses have needed convo id, if you have 4000+ statuses in memory this will get slow, but this allows dynamic update to conversations
New conversation flow:
- fetch relevant statuses (MastoAPI works slightly different, providing "above" and "below" lists instead of one list, doesn't contain status)
- temporarily store which statuses we should display from response data
- display all relevant statuses by getting them from faster
allStatusesObjects
This will not automatically update unfortunately, but I think better mechanism could be implemented there.
Edited by HJ
Merge request reports
Activity
mentioned in issue pleroma#674 (closed)
added 70 commits
-
49b0f0a0...66e60572 - 69 commits from branch
develop
- 307b4ba6 - Merge remote-tracking branch 'upstream/develop' into mastoapi/convos
-
49b0f0a0...66e60572 - 69 commits from branch
added 1 commit
- d6c62fa5 - minor UI improvements - keep current behavior of showing originating post initially
added 2 commits
- Resolved by Shpuld Shpludson
- Resolved by HJ
- Resolved by Shpuld Shpludson
- Resolved by HJ
Looks fine to me apart from minor naming stuff. I honestly think mastoapi is pretty retarded when it comes to not having a proper conversation id. I tried thinking of ways to make the auto update work without massive hacks but it's not simple.
anyway please merge it when you think it's appropriate, you know better what should be merged and in what order
added 44 commits
-
e617ed28...b02085f2 - 43 commits from branch
develop
- 3b5fc889 - Merge remote-tracking branch 'upstream/develop' into mastoapi/convos
-
e617ed28...b02085f2 - 43 commits from branch
Please register or sign in to reply