Skip to content
Snippets Groups Projects

Only connect to chat upon authenticating

Merged Only connect to chat upon authenticating
slice/pleroma-fe:develop into develop
1 unresolved thread
Merged slice requested to merge slice/pleroma-fe:develop into develop
1 unresolved thread

hello! this is my first time contributing to pleroma, so please be aware

something i noticed while using pleroma is that if you are logged out, then cryptic websocket errors get outputted to the console (as outlined in #403 (closed)). (this only happens with pleroma instances that have chat enabled.)

while checking the code, it appears that p-fe makes a connection to the chat channel if chat is enabled, even if we aren't logged in. this patch adds a secondary condition that enforces the existence of a websocket token before attempting to connect to chat. this patch only creates a connection to the chat channel upon authenticating. the websocket token is only set upon verifying credentials, so:

this means that only logged in users are ever able to see chat, but i'm sure that's the intended behavior... right?

Edited by slice

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/modules/api.js
50 50 },
51 51 initializeSocket (store) {
52 52 // Set up websocket connection
53 if (!store.state.chatDisabled) {
53 if (!store.state.chatDisabled && store.state.wsToken) {
  • HJ
    HJ @hj ·
    Maintainer

    yes, however this will probably just disable chat even if it's enabled since this part of code only executed once. I'd move the whole store.dispatch('initializeSocket') into place that gets executed when user logs in (or after credentials are being verified, same thing)

  • S
    slice @slice ·
    Author Contributor

    okay, but that will require extra logic to tear down the chat socket when logging out. this is because the current behavior is to create the socket upon page load. when creating upon login, it's possible to "duplicate" the channel by logging out and logging back in

    Edited by slice
  • slice changed this line in version 2 of the diff

    changed this line in version 2 of the diff

  • Please register or sign in to reply
  • slice added 1 commit

    added 1 commit

    • e618c6ff - Only connect to chat when authenticating in the first place

    Compare with previous version

  • slice changed title from Check for websocket token before connecting to chat to Only connect to chat upon authenticating

    changed title from Check for websocket token before connecting to chat to Only connect to chat upon authenticating

  • slice changed the description

    changed the description

  • lain mentioned in commit f52a33f7

    mentioned in commit f52a33f7

  • lain merged

    merged

  • Sergey Suprunenko mentioned in merge request !894 (merged)

    mentioned in merge request !894 (merged)

    • Please register or sign in to reply