Skip to content

Mobile notifications in nav bar, separate mobile navbar to its own component

Shpuld Shpludson requested to merge feature/mobile-improvements-3 into develop

The notifs button in the navbar opens a drawer from the right, closing the drawer marks notifications as read. With this change going between notifications/timeline/post-status is done with just one tap again without losing state in any of these. you don't even lose scroll position when you just want to check notifications, at the cost of some minor awkwardness when you try to over-scroll the notifications.

Some remaining awkwardness to be fixed:

  • gesture support for the drawer [DONE, for closing only, adding opening for both left side drawer and right notifications drawer by swipe shouldn't be too hard now but not going to do it here]
  • loading more notifications on scroll to make it harder to overscroll [wontfix here]

One slightly questionable but also really useful change: keeping track of mobile layout in JS as well so you can actually do logic based on the layout. this was done here to avoid having 2 notifications components at the same time

Screen_Shot_2019-03-23_at_22.26.26Screen_Shot_2019-03-23_at_22.26.33

Edited by Shpuld Shpludson

Merge request reports

Loading