Mobile notifications in nav bar, separate mobile navbar to its own component
The notifs button in the navbar opens a drawer from the right, closing the drawer marks notifications as read. With this change going between notifications/timeline/post-status is done with just one tap again without losing state in any of these. you don't even lose scroll position when you just want to check notifications, at the cost of some minor awkwardness when you try to over-scroll the notifications.
Some remaining awkwardness to be fixed:
- gesture support for the drawer [DONE, for closing only, adding opening for both left side drawer and right notifications drawer by swipe shouldn't be too hard now but not going to do it here]
- loading more notifications on scroll to make it harder to overscroll [wontfix here]
One slightly questionable but also really useful change: keeping track of mobile layout in JS as well so you can actually do logic based on the layout. this was done here to avoid having 2 notifications components at the same time
Merge request reports
Activity
added 110 commits
-
fd12263c...c829b1a5 - 108 commits from branch
develop
- 31010779 - Merge branch 'develop' into feature/mobile-improvements-3
- c06bcf33 - add gesture to close notifications drawer
-
fd12263c...c829b1a5 - 108 commits from branch
- Resolved by Shpuld Shpludson
- Resolved by Shpuld Shpludson
- src/components/mobile_nav/mobile_nav.js 0 → 100644
33 }, 34 sitename () { return this.$store.state.instance.name } 35 }, 36 methods: { 37 toggleMobileSidebar () { 38 this.$refs.sideDrawer.toggleDrawer() 39 }, 40 openMobileNotifications () { 41 this.notificationsOpen = true 42 }, 43 closeMobileNotifications () { 44 if (this.notificationsOpen) { 45 // make sure to mark notifs seen only when the notifs were open and not 46 // from close-calls. 47 this.notificationsOpen = false 48 this.markNotificationsAsSeen() added 33 commits
-
2879495b...df366a58 - 32 commits from branch
develop
- 46de457f - Merge branch 'develop' into feature/mobile-improvements-3
-
2879495b...df366a58 - 32 commits from branch
added 6 commits
-
46de457f...ae3b92ce - 5 commits from branch
develop
- 89c94485 - fix conflict
-
46de457f...ae3b92ce - 5 commits from branch
mentioned in commit ac28e8c2